-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nwb integration #28
Open
mhturner
wants to merge
35
commits into
main
Choose a base branch
from
nwb_integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nwb integration #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add NWB as a Data object
commented out lines 582 and 583 in the gui.py TEMPORARILY to fix fxn calls for new directory swapping parent dir to normal dir and then subjects/ flies to NWB HDF5 files
…eed to fix loading, changing series, data tree, etc etc
…hen can append to it within thread. Not sure why, but this is how OG stimpack works. Still segfaults on GUI close and need to fix or ditch attribute tree
…rent param keys, like multi-stim suites
Merge path fix from main
…ng, which was causing issues for greater than 255/2 trials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the option of saving .nwb file formats instead of the old visprotocol-based .hdf5 files. A major change in organization is that now each epoch run is associated with a separate .nwb file, instead of a single .hdf5 file holding all of the subjects and epoch runs for that day's experiment. This is required by .nwb format specifications. This necessitated big changes in the GUI that I couldn't figure out how to smoothly switch between, so there are two different GUI versions.
The way to switch to .nwb is to use the NWBData class in data_nwb, e.g. in your lab-pack data.py module you can add:
assuming your config file looks like this:
Then run the nwb-specific GUI with:
python gui_nwb.py
I tested these two ways of running stimpack and both seem to be working OK, but I would recommend testing thoroughly before deploying in your own labs, where people are still using the old file format. We have switched exclusively to .nwb in my lab.