-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Sound #80
base: main
Are you sure you want to change the base?
Improve Sound #80
Conversation
Just checked how to implement ClemensElflein/open_mower_ros#79 in LowLevel code. Think we either need a cyclic send (i.e. 1-10s) config packet from HL side, or a separate "getConfig" packet from LL which request HL to send the config packet. |
Merged all together now.
Look all fine and it's working on my desktop. Please take into account that the following PR is also needed: ClemensElflein/open_mower_ros#80 If interested in a quick test, binaries are already available in my fork: https://github.com/Apehaenger/OpenMower/releases/tag/latest |
Just started a real practice test on my SA type mower. All looks working as expected. Don't see any issues. |
| ------ | -------- | --- | ||
| <kbd>Mon</kbd> | <kbd>4H</kbd> | Volume up | | ||
| <kbd>Tue</kbd> | <kbd>6H</kbd> | Volume down | ||
| <kbd>Wed</kbd> | <kbd>8H</kbd> | ~~Language switch (English, German)~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't work anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed/noticed in my readme.
Will check about the official docs (fully outdated regarding the official docs because I still use the first ones).
We probably also need to notice somewhere, that "save to flash" happen only once a minute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a while to get it running with Hugo. After I realized that docsys template is to old for recent Hugo versions, and downgraded to Hugo v0.110.0, all looks as expected (for me).
Integrated now all sound relevant infos to the official docs ClemensElflein/openmower.de#33.
Or do you notice anything wrong or missing?
before merging we should mention the "the player just plays everything"-issue somewhere (missing resistors in 0.13 kit); also if there is a guide somewhere we should mention those resistors. |
Think this is how it can be done.
This PR mainly:
SD-Card Structure Problem (old/new sound implementation):
I assumed that >90% of the installations in the wild, will have the original DFRobot DFPlayer with the old SD-Card-Structure installed.
Because DFRobot's DFPlayer has the quirk to auto-play the first sound in SD-Cards root, after a reset(), I detect an old SD-Card-Structure in that way, that if there's an auto-played sound with a specific length (shorter than the one of the new SD-Card-Structure) then it's identified as "old SD-Card-Structure". For sure, this works only for those who have an DFRobot DFPlayer.
This (shall) result in the following behavior (tested with a couple of DFPlayer and SD-Cards):
Overcurrent problem on 3.3V (Pico) line
All current OM installation (with sound) already play "Hi", krk, "Hi, I'm Steve ..." and we haven't heard of died Pico (VREG) till now.
So this sound PR also stop (by default) after "Hi, I'm Steve ...", except it got compiled with
DFPIS5V
(already added to CI firmware build)For sure this doubles our firmware binaries :-/ But does it matter?
firmware.zip