Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Update Anabolic Rejuvenation and Accelerated Resuscitation with EoCified healing #77658

Merged
merged 9 commits into from
Nov 8, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Nov 7, 2024

Summary

Mods "[MoM] Update Anabolic Rejuvenation and Accelerated Resuscitation with EoCified healing"

Purpose of change

Mirror of #77657, converts the healing of both powers over to EoC, which lets it run faster and prevent you from bleeding to death in addition to healing you.

Describe the solution

Copy over the EoC. Set the MoM version to be affected by Nether Attunement, intelligence, and power level, as normal.

Describe alternatives you've considered

Testing

Caused bleeding and injury and turned on anabolic rejuvenation. It worked.

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions labels Nov 7, 2024
@Hyperseeker
Copy link
Contributor

You may have forgotten to set category and description for the PR.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Nov 7, 2024
@Standing-Storm
Copy link
Contributor Author

Also looks like the formatting didn't run on save. I might have to break up that 6-deep run_eocs chain

@Hyperseeker
Copy link
Contributor

Have you considered iterating over an array of strings, each a body part ID? This might shorten your EOC significantly if it's possible.

@Standing-Storm
Copy link
Contributor Author

I don't believe it's possible to iterate over an array with EoCs, unfortunately.

@Hyperseeker
Copy link
Contributor

Imagine that you can. :P

@Standing-Storm
Copy link
Contributor Author

Standing-Storm commented Nov 7, 2024

Oh, there's a special carveout for bodyparts? That explains it.

Edit: Looks like a bad idea at the moment:

Untitled2

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 8, 2024
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Nov 8, 2024
Standing-Storm and others added 2 commits November 7, 2024 19:06
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Nov 8, 2024
@Night-Pryanik Night-Pryanik merged commit 11efb63 into CleverRaven:master Nov 8, 2024
18 of 24 checks passed
@Standing-Storm Standing-Storm deleted the anabolic-eoc branch November 8, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants