Query the player on whether he really want to cut other people's stuff #77932
+41
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Query the player on whether he really want to cut other people's stuff"
Purpose of change
query_consume_ownership
.Describe the solution
query_consume_ownership
and applied it to disassembling check to eliminate duplicating the code.salvage_actor::use
.Describe alternatives you've considered
None.
Testing
Tried to disassemble prisoners' stuff at island prison type B. Got a prompt. Answered no, answered yes.
Tried to cut prisoners' stuff at island prison type B. Got a prompt. Answered no, answered yes.
Tried to disassemble veterinarian's stuff at animal shelter. Got a prompt. Answered no, answered yes.
Tried to cut veterinarian's stuff at animal shelter. Got a prompt. Answered no, answered yes.
Additional context
I also wanted to mention that trying to disassemble/cut factionless NPC's stuff triggers immediate hostile attitude from that NPC, contrary to trying to disassemble/cut faction stuff, which allows you to do it three (!) times before they turn hostile towards you. Their faction opinion towards you will lower every time, but still. I personally find immediate reaction much more "natural", and I wanted to change faction reaction to be immediate too, but I wanted to hear other opinions too, or maybe even open an issue regarding that.