CompatHelper: bump compat for Static to 1, (keep existing compat) #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
compathelper/new_version/2024-06-27-14-04-34-664-03416058285
branch
from
b5222e1
to
5f1bbb2
Compare
|
Is The only reference I could find is and the package is not used in the file Can we maybe remove this dependency? |
charleskawczynski
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
I don't think it's used anymore. Would you mind letting #1791 go through first (if we're going to move forward with it)?
It's unfortunate that julia occasionally scrambles the packages in the Project.toml like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
Staticpackage from0.4, 0.5, 0.6, 0.7, 0.8to0.4, 0.5, 0.6, 0.7, 0.8, 1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.