Use RelativeSolutionTolerance #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 93.09% // Head: 93.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 93.09% 93.41% +0.32%
==========================================
Files 9 9
Lines 1071 1109 +38
==========================================
+ Hits 997 1036 +39
+ Misses 74 73 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Note to self: try without catching |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 26, 2022
140: Use RelativeSolutionTolerance r=charleskawczynski a=charleskawczynski This PR addresses one of the check boxes in #134, by changing from `SolutionTolerance` to `RelativeSolutionTolerance`. One downside of this, unfortunately, is that it's a breaking change, but I think it's fine if we know that this is what we want in the long run. Alternatively, we could require users to pass in `::RootSolvers.AbstractTolerance`, which would make the interface less likely to be breaking, however this means that our interface would be tied to using `RootSolvers`, so it's not a complete win to do that. It looks like all the tests pass with these changes. Co-authored-by: Charles Kawczynski <[email protected]>
|
bors r- |
|
Canceled. |
charleskawczynski
force-pushed
the
ck/relative_sol_tol
branch
from
945be7d
to
e57d9af
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses one of the check boxes in #134, by changing from
SolutionTolerancetoRelativeSolutionTolerance.One downside of this, unfortunately, is that it's a breaking change, but I think it's fine if we know that this is what we want in the long run.
Alternatively, we could require users to pass in
::RootSolvers.AbstractTolerance, which would make the interface less likely to be breaking, however this means that our interface would be tied to usingRootSolvers, so it's not a complete win to do that.It looks like all the tests pass with these changes.