feat: json string column #1034
Merged
feat: json string column #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpencerTorres
force-pushed
the
json_string_column
branch
from
304aad8 to
e6773a5
Compare
SpencerTorres
force-pushed
the
json_string_column
branch
from
e6773a5 to
1353ef1
Compare
ernado
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #939
This adds a
ColJSONStrtype for properly encodingJSONcolumns on the server. It's justColStrbut with au64prefix for the JSONserializationVersion. Requiresoutput_format_native_write_json_as_stringto be enabled, however this setting does not currently work due to this bug ClickHouse/ClickHouse#73924.Checklist
Let me know if I need to add/remove anything else. Thanks!