Skip to content

Conversation

@botaturganova
Copy link
Contributor

Description

  • Added concept Buttons for SwiftUI

Issue Solved

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2024

CLA assistant check
All committers have signed the CLA.

@PragatiVerma18 PragatiVerma18 self-assigned this Dec 13, 2024
@PragatiVerma18 PragatiVerma18 added the status: under review Issue or PR is currently being reviewed label Dec 16, 2024
Copy link
Collaborator

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @botaturganova, thanks for contributing this entry. I have some suggestions, I have put some comments, please check them and do the required changes. Let me know if you have any questions.

Copy link
Collaborator

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @botaturganova, this now seems good for a second review! 🚀

@dakshdeepHERE dakshdeepHERE self-assigned this Jan 22, 2025
@dakshdeepHERE dakshdeepHERE added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jan 22, 2025
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed the code snippets by running them all locally and evrything looks good, let's merge this :)

@dakshdeepHERE dakshdeepHERE added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jan 26, 2025
@dakshdeepHERE dakshdeepHERE merged commit 51c2038 into Codecademy:main Jan 26, 2025
7 checks passed
@github-actions
Copy link

👋 @botaturganova
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/swiftui/buttons

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants