[chore] Update primevue to 4.2.5 #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
I think should be in sync as well: npm/@primevue/[email protected] |
Already included in da96084 |
huchenlei
commented
Jan 20, 2025
There was a problem hiding this comment.
Remove this unused component.
huchenlei
commented
Jan 20, 2025
| @@ -1,35 +1,17 @@ | |||
| <template> | |||
| <div class="color-picker-wrapper flex items-center gap-2"> | |||
| <ColorPicker v-model="modelValue"> | |||
There was a problem hiding this comment.
Remove incorrectly generated code. ColorPicker does not have a header slot.
huchenlei
commented
Jan 20, 2025
| @@ -82,10 +82,14 @@ test.describe('Node search box', () => { | |||
| test('Has correct aria-labels on search results', async ({ comfyPage }) => { | |||
| const node = 'Load Checkpoint' | |||
| await comfyPage.doubleClickCanvas() | |||
| await comfyPage.searchBox.fillAndSelectFirstNode(node) | |||
There was a problem hiding this comment.
fillAndSelectFirstNode do the click in the first dropdown item, which will cause the searchbox to be dismissed. This will cause issue for the subsequent check of dropdown element, so change to inline those selection logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates primevue and @primevue/themes to 4.2.5.
┆Issue is synchronized with this Notion page by Unito