enh: Ask user: Capture error in Sentry when app crashes #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oto-ciulis-tt
commented
Nov 5, 2024
oto-ciulis-tt
commented
robinjhuang
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Can we change the text to "Automatically send crash reports"?
Also, the first time the app starts up the comfy.settings.json file may not exist and this choice will be removed. We should apply this change after the launchPythonServer has returned.
Also, we don't want to overwrite the entire file since it may be edited elsewhere (by the ComfyUI python server). We should just only change the single field.
|
Closes #167 |
robinjhuang
requested changes
Nov 6, 2024
robinjhuang
approved these changes
Nov 8, 2024
oto-ciulis-tt
deleted the
enh/Ask-user--Capture-error-in-Sentry-when-app-crashes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.