Skip to content

enh: Ask user: Capture error in Sentry when app crashes #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 8, 2024
Merged

enh: Ask user: Capture error in Sentry when app crashes #184

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
90b94ce
enh: Ask user: Capture error in Sentry when app crashes
otociulis Nov 5, 2024
ddb864b
Reverting testing changes
otociulis Nov 5, 2024
262b687
Merge branch 'main' into enh/Ask-user--Capture-error-in-Sentry-when-a…
otociulis Nov 5, 2024
43db4ce
Small update
otociulis Nov 5, 2024
42b47a9
Removing saving portion of settings
otociulis Nov 6, 2024
17a859f
Reverting UI change
otociulis Nov 6, 2024
0fe8993
Reverting changes
otociulis Nov 6, 2024
c42b0fe
Merge branch 'main' into enh/Ask-user--Capture-error-in-Sentry-when-a…
otociulis Nov 6, 2024
7362adb
Reverting UI change
otociulis Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,18 @@ if (!gotTheLock) {
Sentry.init({
dsn: SENTRY_URL_ENDPOINT,
autoSessionTracking: false,
beforeSend(event, hint) {
if (event.extra?.comfyUIExecutionError) {
async beforeSend(event, hint) {
if (event.extra?.comfyUIExecutionError || comfySettings.sendCrashStatistics) {
return event;
}

//TODO (use default pop up behavior).
return event;
const { response } = await dialog.showMessageBox({
title: 'Send Crash Statistics',
message: `Would you like to send crash statistics to the team?`,
buttons: ['Always send crash reports', 'Do not send crash report'],
});

return response === 0 ? event : null;
},
integrations: [
Sentry.childProcessIntegration({
Expand Down
Loading