-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for visa mobile (on-site) #85
Conversation
334139b
to
f1521f0
Compare
d1a72b6
to
2deaaee
Compare
0a87f63
to
db2a61b
Compare
b738b69
to
49daa07
Compare
Founded bugs:
|
Only required change for now: let's do something with After discussion with @jakubtobiasz we decided to hardcode 9 digits numbers and add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to have an E2E test here, as with VisaMobile it should be possible; check the BLIK E2E for a reference or just catch me on Slack
4d37b8d
to
b92c26b
Compare
The validation do not work as expected. I allow phone numbers to be 7 digits Screen.Recording.2024-10-18.at.20.57.35.mov |
according to their docs, the phone number |
6b3c489
to
fe9f293
Compare
…ion. Change provided value from 11 to 9 digit number
fe9f293
to
218e2b7
Compare
218e2b7
to
66715fe
Compare
@@ -5,6 +5,7 @@ | |||
namespace Symfony\Component\DependencyInjection\Loader\Configurator; | |||
|
|||
use CommerceWeavers\SyliusTpayPlugin\Form\DataTransformer\CardTypeDataTransformer; | |||
use CommerceWeavers\SyliusTpayPlugin\Form\DataTransformer\VisaMobilePhoneDataTransformer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed. Should be removed
No description provided.