Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for visa mobile (on-site) #85

Merged
merged 10 commits into from
Oct 21, 2024

Conversation

arti0090
Copy link
Contributor

No description provided.

@arti0090 arti0090 linked an issue Oct 15, 2024 that may be closed by this pull request
@arti0090 arti0090 force-pushed the 47-add-support-for-visa-mobile branch from 334139b to f1521f0 Compare October 15, 2024 13:23
@arti0090 arti0090 marked this pull request as ready for review October 15, 2024 13:30
@arti0090 arti0090 changed the title 47 add support for visa mobile add support for visa mobile (redirect) Oct 15, 2024
@arti0090 arti0090 marked this pull request as draft October 15, 2024 15:22
@arti0090 arti0090 force-pushed the 47-add-support-for-visa-mobile branch from d1a72b6 to 2deaaee Compare October 16, 2024 17:10
@arti0090 arti0090 changed the title add support for visa mobile (redirect) add support for visa mobile (on-site) Oct 16, 2024
@arti0090 arti0090 force-pushed the 47-add-support-for-visa-mobile branch 4 times, most recently from 0a87f63 to db2a61b Compare October 17, 2024 09:46
@arti0090 arti0090 marked this pull request as ready for review October 17, 2024 09:54
@arti0090 arti0090 force-pushed the 47-add-support-for-visa-mobile branch 3 times, most recently from b738b69 to 49daa07 Compare October 17, 2024 10:34
@lchrusciel
Copy link
Member

Founded bugs:

  • If you use number with + at the beginning you are not able to fill 9 numbers of phone
  • if you proceed with wrong number, you end up with 500 error
    perhaps we should add two separate boxes for phone number and skip validation entirely

@lchrusciel
Copy link
Member

Only required change for now: let's do something with 48 prefix. Either we should support +48 or omit this value in the first iteration.

After discussion with @jakubtobiasz we decided to hardcode 9 digits numbers and add +48 (if needed) on backend

Copy link
Member

@jakubtobiasz jakubtobiasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to have an E2E test here, as with VisaMobile it should be possible; check the BLIK E2E for a reference or just catch me on Slack

assets/shop/js/_visa_mobile.js Outdated Show resolved Hide resolved
config/config/sylius_fixtures.php Outdated Show resolved Hide resolved
tests/Api/Shop/PayingForOrdersByVisaMobileTest.php Outdated Show resolved Hide resolved
tests/Unit/Api/Command/PayByGooglePayHandlerTest.php Outdated Show resolved Hide resolved
@arti0090 arti0090 force-pushed the 47-add-support-for-visa-mobile branch 4 times, most recently from 4d37b8d to b92c26b Compare October 18, 2024 13:31
assets/shop/js/_visa_mobile.js Outdated Show resolved Hide resolved
src/Form/Type/TpayPaymentDetailsType.php Outdated Show resolved Hide resolved
src/Model/PaymentDetails.php Show resolved Hide resolved
@lchrusciel
Copy link
Member

The validation do not work as expected. I allow phone numbers to be 7 digits

Screen.Recording.2024-10-18.at.20.57.35.mov

@lchrusciel
Copy link
Member

according to their docs, the phone number 12345678904 should not be accepted, but we cannot check it, as only 9 digits are accepted in our field. Let's make it at least 9 without upper limit

@arti0090 arti0090 force-pushed the 47-add-support-for-visa-mobile branch from 6b3c489 to fe9f293 Compare October 19, 2024 20:47
@arti0090 arti0090 force-pushed the 47-add-support-for-visa-mobile branch from fe9f293 to 218e2b7 Compare October 19, 2024 20:48
@arti0090 arti0090 force-pushed the 47-add-support-for-visa-mobile branch from 218e2b7 to 66715fe Compare October 19, 2024 20:58
@@ -5,6 +5,7 @@
namespace Symfony\Component\DependencyInjection\Loader\Configurator;

use CommerceWeavers\SyliusTpayPlugin\Form\DataTransformer\CardTypeDataTransformer;
use CommerceWeavers\SyliusTpayPlugin\Form\DataTransformer\VisaMobilePhoneDataTransformer;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed. Should be removed

@lchrusciel lchrusciel merged commit 4aaff3f into main Oct 21, 2024
4 checks passed
@lchrusciel lchrusciel deleted the 47-add-support-for-visa-mobile branch October 21, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Visa Mobile
3 participants