Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚧 Testing input injector with 1.2.221109.1 WinAppSDK in CI #183

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

🚧 Testing input injector with 1.2.221109.1 WinAppSDK in CI #183

wants to merge 13 commits into from

Conversation

michael-hawker
Copy link
Member

Not working locally, but want to get output from CI as well, think MSTest discovery is still broken by update from 1.0.3 to 1.1.2. Going to open issue.

@michael-hawker michael-hawker force-pushed the llama/input-injection-test branch from 23c2fb2 to 4603e0f Compare July 5, 2022 18:37
@michael-hawker
Copy link
Member Author

Looks like installing the SDK is still broken for MSTest based projects? Added comment here.

Also filed microsoft/WindowsAppSDK#2706 in general for MSTest discovery being broken in VS locally with the update to 1.1.x over 1.0.3.

@michael-hawker michael-hawker mentioned this pull request Jul 14, 2022
Open
michael-hawker
michael-hawker commented Jul 21, 2022
View reviewed changes
Copy link
Member Author

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just using GitHub to test incrementing the WinAppSDK version to the new hotfix release they did. Need to rebase this branch later, as we centralized these properties in main.

common/Labs.MultiTarget.props Outdated Show resolved Hide resolved
common/Labs.WinAppSdk.props Outdated Show resolved Hide resolved
labs/CanvasLayout/samples/CanvasLayout.WinAppSdk/CanvasLayout.WinAppSdk.csproj Outdated Show resolved Hide resolved
labs/SizerBase/samples/SizerBase.WinAppSdk/SizerBase.WinAppSdk.csproj Outdated Show resolved Hide resolved
template/lab/samples/ProjectTemplate.WinAppSdk/ProjectTemplate.WinAppSdk.csproj Outdated Show resolved Hide resolved
@michael-hawker michael-hawker changed the title 🚧 Testing input injector with 1.1.2 WinAppSDK in CI 🚧 Testing input injector with 1.1.3 WinAppSDK in CI Jul 21, 2022
@michael-hawker michael-hawker force-pushed the llama/input-injection-test branch from 7415c91 to 74ac8f5 Compare July 21, 2022 17:22
@michael-hawker michael-hawker mentioned this pull request Jul 22, 2022
Closed
@michael-hawker
Copy link
Member Author

Filed microsoft/WindowsAppSDK#2768 for tracking our issues with installing the 1.1.x series of packages still on GitHub Actions.

@michael-hawker michael-hawker force-pushed the llama/input-injection-test branch from 7baa9ea to 7a127a9 Compare August 22, 2022 23:24
@michael-hawker michael-hawker changed the title 🚧 Testing input injector with 1.1.3 WinAppSDK in CI 🚧 Testing input injector with 1.1.4 WinAppSDK in CI Aug 22, 2022
@michael-hawker michael-hawker force-pushed the llama/input-injection-test branch from 7a127a9 to f2f2e04 Compare November 15, 2022 18:41
@michael-hawker michael-hawker changed the title 🚧 Testing input injector with 1.1.4 WinAppSDK in CI 🚧 Testing input injector with 1.2.221109.1 WinAppSDK in CI Nov 15, 2022
@michael-hawker michael-hawker force-pushed the llama/input-injection-test branch 3 times, most recently from 6ac2a45 to 9f2f637 Compare November 15, 2022 22:47
@michael-hawker michael-hawker force-pushed the llama/input-injection-test branch from 9f2f637 to 003be08 Compare November 15, 2022 23:26
@michael-hawker
Copy link
Member Author

This PR blocked in CI from running by: actions/runner-images#6585

@michael-hawker
Fix issue with Offset in Windows App SDK for Window Chrome in Input I…
219b3cd 
…njection Tests
@michael-hawker
Update global.json to ensure we're on .NET 6 still for Uno-Check
ffceeef 
(Basically, ensure we're on a version of .NET we're expecting in the CI to build with until we want to upgrade.)
@michael-hawker
Update Uno Check Dependency
e350121
@michael-hawker
Switch to using CsWin32 to generate native methods for pinvoke
aa09503 
Start instance based fluent pattern for InputSimulator
Move Bounds logic to simulator
@michael-hawker
Add some initial helpers for the InputSimulator
ea94942 
Fix issue with UWP and WeakReference
@michael-hawker
Copy link
Member Author

Well, the WinUI 3 pipeline failed due to the CommunityToolkit/Tooling-Windows-Submodule#9 issue... and there's some info about NuGet restore in the linux build... BUT

The WinUI 3 Injection test ran in the CI:

image

At least this shows that it looks viable to do this as a methodology.

Been tinkering with a test for GridSplitter to check the mouse cursor changing when over the splitter for the bug I last called out for #101, that'll be a bit more interesting to run in the CI.

This was referenced Dec 7, 2022
Closed
Merged
@michael-hawker
Copy link
Member Author

Should look at the Input helpers from the WinUI library as well to look at how their tests are written and see what makes sense to have similar helpers on in our new API: https://github.com/microsoft/microsoft-ui-xaml/blob/main/test/testinfra/MUXTestInfra/Common/InputHelper.cs

@michael-hawker michael-hawker mentioned this pull request Jan 26, 2023
Closed
@michael-hawker michael-hawker mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michael-hawker