Updated sonLib to include splitting large records for Redis #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @masri2019 ! Will try this out as soon as I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I have updated the sonLib submodule to the redis branch on its repo. If the large-record PR for sonLib gets merged I'll update it to the master before merging the current PR.
I ran the evolver mammals test for max record sizes of 510M and 400. Both of them passed successfully. The first one was the real threshold due to Redis limitation and the second one was to force splitting to make sure the splitting procedure works well (Since for evolver mammals we don't experience records larger than 510M).
@glennhickey I remember you once said you have a record about 1GB. Could you please test it on that?