Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: qa localisation #489

Merged
merged 16 commits into from
Jan 20, 2025
Merged

fix: qa localisation #489

merged 16 commits into from
Jan 20, 2025

Conversation

khanti42
Copy link
Collaborator

This PR is to add missing translation, coming from QA testing

@khanti42 khanti42 requested a review from a team as a code owner January 17, 2025 13:52
@khanti42 khanti42 requested review from Akaryatrh and stanleyyconsensys and removed request for a team January 17, 2025 13:52
stanleyyconsensys
stanleyyconsensys previously approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but lint error

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

stanleyyconsensys
stanleyyconsensys approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanti42 khanti42 added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit d1bdd22 Jan 20, 2025
21 checks passed
@khanti42 khanti42 deleted the fix/sf-761-qa-fix branch January 20, 2025 09:01
@github-actions github-actions bot mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanleyyconsensys stanleyyconsensys stanleyyconsensys approved these changes

@Akaryatrh Akaryatrh Awaiting requested review from Akaryatrh Akaryatrh is a code owner automatically assigned from Consensys/snaps-factory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khanti42 @stanleyyconsensys