chore: fix comments

packages/starknet-snap/locales/RULES.md

@@ -1,13 +1,15 @@
 ### Rules for Adding New Fields to the Language File
 
 1. **Key Naming Convention:**
+
    - Use **English text** to derive the key.
    - The key should be **camelized** (first word lowercase, subsequent words capitalized).
    - Keep the key to **no more than 5 words**.
    - If the text in English is **shorter than 5 words**, camelize the entire phrase.
    - For **longer text**, use a **concise and meaningful key** (this is a soft constraint).
 
 2. **Dynamic Text Placeholders:**
+
    - Use `{1}`, `{2}`, etc., for dynamic placeholders in messages.
    - Example:
      - `"visitCompanionDappAndUpgrade": { "message": "Visit the [companion dapp for Starknet]({1}) and click “Upgrade”.\nThank you!" }`

packages/starknet-snap/locales/en.json

@@ -25,7 +25,7 @@
     "amount": {
       "message": "Amount"
     },
-    "amountWythSymbol": {
+    "amountWithSymbol": {
       "message": "Amount ({1})"
     },
     "balance": {
@@ -55,7 +55,7 @@
     "compiledClassHash": {
       "message": "Compiled Class Hash"
     },
-    "confirmPrivateKeyAction": {
+    "confirmPrivateKeyToDisplay": {
       "message": "Confirming this action will display your private key. Ensure you are in a secure environment."
     },
     "contract": {
@@ -112,7 +112,7 @@
     "signer": {
       "message": "Signer"
     },
-    "snapUpdate": {
+    "snapIsUpToDate": {
       "message": "Your Starknet Snap is now up-to-date!"
     },
     "starknetPrivateKeyConfidential": {
@@ -148,7 +148,7 @@
     "visitCompanionDappAndUpgrade": {
       "message": "Visit the [companion dapp for Starknet]({1}) and click “Upgrade”.\nThank you!"
     },
-    "walletCompatibility": {
+    "walletIsCompatible": {
       "message": "Your MetaMask wallet is now compatible with Starknet!"
     }
   }

packages/starknet-snap/locales/fr.json

@@ -25,7 +25,7 @@
     "amount": {
       "message": "Montant"
     },
-    "amountWythSymbol": {
+    "amountWithSymbol": {
       "message": "Montant ({1})"
     },
     "balance": {
@@ -55,7 +55,7 @@
     "compiledClassHash": {
       "message": "Hash de la classe compilée"
     },
-    "confirmPrivateKeyAction": {
+    "confirmPrivateKeyToDisplay": {
       "message": "Confirmer cette action affichera votre clé privée. Assurez-vous d'être dans un environnement sécurisé."
     },
     "contract": {
@@ -112,7 +112,7 @@
     "signer": {
       "message": "Signataire"
     },
-    "snapUpdate": {
+    "snapIsUpToDate": {
       "message": "Votre Starknet Snap est maintenant à jour !"
     },
     "starknetPrivateKeyConfidential": {
@@ -148,7 +148,7 @@
     "visitCompanionDappAndUpgrade": {
       "message": "Visitez la [dapp compagnon pour Starknet]({1}) et cliquez sur “Upgrade”.\nMerci !"
     },
-    "walletCompatibility": {
+    "walletIsCompatible": {
       "message": "Votre portefeuille MetaMask est désormais compatible avec Starknet !"
     }
   }

packages/starknet-snap/src/index.tsx

@@ -303,7 +303,7 @@ export const onInstall: OnInstallHandler = async () => {
   const translate = getTranslator();
   await ensureJsxSupport(
     <Box>
-      <Text>{translate('walletCompatibility')}</Text>
+      <Text>{translate('walletIsCompatible')}</Text>
       <Text>
         {translate('accountManagementIntro')}{' '}
         <Link href={getDappUrl()}>{translate('companionDapp')}</Link>.
@@ -317,7 +317,7 @@ export const onUpdate: OnUpdateHandler = async () => {
   const translate = getTranslator();
   await ensureJsxSupport(
     <Box>
-      <Text>{translate('snapUpdate')}</Text>
+      <Text>{translate('snapIsUpToDate')}</Text>
       <Text>
         {translate('accountManagementReminder')}{' '}
         <Link href={getDappUrl()}>{translate('companionDapp')}</Link>.

packages/starknet-snap/src/signDeployAccountTransaction.ts

@@ -5,6 +5,7 @@ import type {
   ApiParamsWithKeyDeriver,
   SignDeployAccountTransactionRequestParams,
 } from './types/snapApi';
+import { getTranslator } from './utils/locale';
 import { logger } from './utils/logger';
 import { toJson } from './utils/serializer';
 import {
@@ -53,12 +54,13 @@ export async function signDeployAccountTransaction(
     );
 
     if (requestParamsObj.enableAuthorize) {
+      const translate = getTranslator();
       const response = await wallet.request({
         method: 'snap_dialog',
         params: {
           type: DialogType.Confirmation,
           content: panel([
-            heading('Do you want to sign this transaction?'),
+            heading(translate('signTransactionPrompt')),
             ...snapComponents,
           ]),
         },

packages/starknet-snap/src/ui/components/DisplayPrivateKeyUI.tsx

@@ -15,7 +15,7 @@ export const DisplayPrivateKeyDialogUI: SnapComponent = () => {
       <Heading>Are you sure you want to reveal your private key?</Heading>
       <Box direction="horizontal">
         <Icon name="warning" size="md" />
-        <Text>{translate('confirmPrivateKeyAction')}</Text>
+        <Text>{translate('confirmPrivateKeyToDisplay')}</Text>
       </Box>
     </Box>
   );

packages/starknet-snap/src/upgradeAccContract.ts

@@ -7,6 +7,7 @@ import type {
 } from './types/snapApi';
 import { ContractFuncName } from './types/snapState';
 import { ACCOUNT_CLASS_HASH, CAIRO_VERSION_LEGACY } from './utils/constants';
+import { getTranslator } from './utils/locale';
 import { logger } from './utils/logger';
 import { toJson } from './utils/serializer';
 import {
@@ -105,13 +106,13 @@ export async function upgradeAccContract(params: ApiParamsWithKeyDeriver) {
       maxFee,
       network,
     );
-
+    const translate = getTranslator();
     const response = await wallet.request({
       method: 'snap_dialog',
       params: {
         type: DialogType.Confirmation,
         content: panel([
-          heading('Do you want to sign this transaction?'),
+          heading(translate('signTransactionPrompt')),
           ...dialogComponents,
         ]),
       },

packages/starknet-snap/test/src/upgradeAccContract.test.ts

@@ -153,44 +153,6 @@ describe('Test function: upgradeAccContract', function () {
       estimateFeeStub = sandbox.stub(utils, 'estimateFee');
     });
 
-    it('should use provided max fee to execute txn when max fee provided', async function () {
-      await loadLocale();
-      (apiParams.requestParams as UpgradeTransactionRequestParams).maxFee =
-        '10000';
-      walletStub.rpcStubs.snap_dialog.resolves(true);
-      executeTxnStub.resolves(sendTransactionResp);
-
-      const address = (
-        apiParams.requestParams as UpgradeTransactionRequestParams
-      ).contractAddress;
-      const calldata = CallData.compile({
-        implementation: ACCOUNT_CLASS_HASH,
-        calldata: [0],
-      });
-
-      const txnInvocation = {
-        contractAddress: address,
-        entrypoint: 'upgrade',
-        calldata,
-      };
-
-      const result = await upgradeAccContract(apiParams);
-
-      expect(executeTxnStub).to.calledOnce;
-      expect(executeTxnStub).to.calledWith(
-        STARKNET_SEPOLIA_TESTNET_NETWORK,
-        address,
-        'pk',
-        txnInvocation,
-        undefined,
-        {
-          maxFee: num.toBigInt(10000),
-        },
-        CAIRO_VERSION_LEGACY,
-      );
-      expect(result).to.be.equal(sendTransactionResp);
-    });
-
     it('should use calculated max fee to execute txn when max fee not provided', async function () {
       await loadLocale();
       walletStub.rpcStubs.snap_dialog.resolves(true);