(test): Upgrade to Rails 7.2 #7559
Draft
+427
−293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adi-herwana-nus
force-pushed
the
adi/rails-upgrade
branch
4 times, most recently
from
1d135e0
to
069fe1e
Compare
added 2 commits
September 20, 2024 22:18
- removed unused rails_utils dependency - removed deprecated fixture_path config keys - updated database extension to sync with internal change
- migrated secret_key_base from Rails secrets to (encrypted) credentials - updated all enum declarations from deprecated keyword args to positional args - updated gem calculated_attributes to compatible self-maintained fork - updated third-party gems unread,active_record_upsert to compatible bleeding-edge commits - mock _default_attributes also for specs mocking load_schema (needed due to internal refactoring in 7.2) - set eager_load to true in all environments to ensure table_name overrides loaded - updated carrierwave to v3, amended relevant test case
adi-herwana-nus
force-pushed
the
adi/rails-upgrade
branch
from
069fe1e
to
5f2878b
Compare
added 16 commits
September 21, 2024 02:51
adi-herwana-nus
force-pushed
the
adi/rails-upgrade
branch
from
48ee877
to
bf65394
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| timestamp = Time.zone.now.to_i.to_s | ||
| "Course #{timestamp + n.to_s}" | ||
| timestamp = Time.zone.now.to_i.to_s(36) | ||
| "#{prefix}#{timestamp}#{n.to_s}" |
There was a problem hiding this comment.
[Correctable] Lint/RedundantStringCoercion: Redundant use of Object#to_s in interpolation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.