Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Rails 7.2, Ruby 3.3; Increased RSpec test reliability #7559

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Upgrade to Rails 7.2, Ruby 3.3; Increased RSpec test reliability #7559

merged 5 commits into from
Oct 9, 2024

Commits on Oct 8, 2024

  1. chore(rails): upgrade to rails 7.1.4 

    - removed unused rails_utils dependency
- removed deprecated fixture_path config keys
- updated database extension to sync with internal change
    adi-herwana-nus committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    67215a4 View commit details
    Browse the repository at this point in the history

  2. chore(rails): upgrade to rails 7.2.1 

    - migrated secret_key_base from Rails secrets to (encrypted) credentials
- updated all enum declarations from deprecated keyword args to positional args
- updated gem calculated_attributes to compatible self-maintained fork
- updated third-party gems unread,active_record_upsert to compatible bleeding-edge commits
- mock _default_attributes also for specs mocking load_schema (needed due to internal refactoring in 7.2)
- set eager_load to true in all environments to ensure table_name overrides loaded
- updated carrierwave to v3, amended relevant test case
    adi-herwana-nus committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    75fb797 View commit details
    Browse the repository at this point in the history

  3. chore(ruby): upgrade to ruby 3.3.5 

    - fix error due to tar files being frozen strings
    adi-herwana-nus committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    cd99514 View commit details
    Browse the repository at this point in the history

  4. test: improved rspec test reliability 

    - updated Keycloak config to allow user delete/overwrite from DB
- refactored various tests/helper functions to phase out sleep stmts
- improved handling of 'New Question' flow to account for page animations
- added search queries to tests looking for objects in paginated lists
- increased Capybara max wait time from 5s to 10s
    adi-herwana-nus committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    bd14f1b View commit details
    Browse the repository at this point in the history

  5. test: other test improvements 

    - added missing translations from #7542
- migrated away from deprecated codecov gem
    adi-herwana-nus committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ff3e296 View commit details
    Browse the repository at this point in the history