Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application.files refactor #732

Merged
merged 22 commits into from
Oct 16, 2024

address one comment from Matt

6198a14
Select commit
Loading
Failed to load commit list.
Merged

Application.files refactor #732

address one comment from Matt
6198a14
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 16, 2024 in 0s

47.32% (target 0.00%)

View this Pull Request on Codecov

47.32% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 99.31507% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.32%. Comparing base (cce16e6) to head (6198a14).
Report is 18 commits behind head on smartsim-refactor.

Files with missing lines Patch % Lines
smartsim/_core/commands/command_list.py 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           smartsim-refactor     #732      +/-   ##
=====================================================
+ Coverage              40.45%   47.32%   +6.87%     
=====================================================
  Files                    110      109       -1     
  Lines                   7326     6573     -753     
=====================================================
+ Hits                    2964     3111     +147     
+ Misses                  4362     3462     -900     
Files with missing lines Coverage Δ
smartsim/_core/commands/command.py 95.34% <100.00%> (-0.31%) ⬇️
smartsim/_core/generation/generator.py 100.00% <100.00%> (+2.22%) ⬆️
smartsim/_core/generation/operations/operations.py 100.00% <100.00%> (ø)
...rtsim/_core/generation/operations/utils/helpers.py 100.00% <100.00%> (ø)
smartsim/builders/ensemble.py 93.04% <ø> (ø)
smartsim/entity/application.py 90.24% <100.00%> (ø)
smartsim/entity/files.py 52.17% <ø> (-23.10%) ⬇️
smartsim/_core/commands/command_list.py 92.85% <66.66%> (ø)

... and 9 files with indirect coverage changes