Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SmartSim to use Dragon V0.10 #753

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from

Style

eb7639b
Select commit
Loading
Failed to load commit list.
Open

Update SmartSim to use Dragon V0.10 #753

Style
eb7639b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 1, 2024 in 0s

81.82% (target 0.00%)

View this Pull Request on Codecov

81.82% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 35.84906% with 34 lines in your changes missing coverage. Please review.

Project coverage is 81.82%. Comparing base (d7d979e) to head (eb7639b).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
smartsim/_core/launcher/dragon/dragonBackend.py 27.65% 34 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #753      +/-   ##
===========================================
- Coverage    83.91%   81.82%   -2.09%     
===========================================
  Files           83       84       +1     
  Lines         6284     7081     +797     
===========================================
+ Hits          5273     5794     +521     
- Misses        1011     1287     +276     
Files with missing lines Coverage Δ
smartsim/_core/utils/__init__.py 100.00% <ø> (ø)
smartsim/_core/utils/helpers.py 91.58% <100.00%> (+0.12%) ⬆️
smartsim/_core/launcher/dragon/dragonBackend.py 35.35% <27.65%> (-0.11%) ⬇️

... and 46 files with indirect coverage changes