Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPDX-8333 Suggested Tags Fix #1111

Merged
merged 8 commits into from
Oct 4, 2024
Merged

MPDX-8333 Suggested Tags Fix #1111

merged 8 commits into from
Oct 4, 2024

Conversation

caleballdrin
Copy link
Contributor

@caleballdrin caleballdrin commented Oct 3, 2024 •
edited
Loading

Description

https://jira.cru.org/browse/MPDX-8333

  • Fix suggested tags not saving when completing tasks
  • Other small fixes

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@caleballdrin caleballdrin self-assigned this Oct 3, 2024
@caleballdrin caleballdrin added the Preview Environment Add this label to create an Amplify Preview label Oct 3, 2024
@caleballdrin caleballdrin requested a review from dr-bizz October 3, 2024 05:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

Preview branch generated at https://suggested-tags-fix.d3dytjb8adxkk5.amplifyapp.com

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024 •
edited
Loading

Bundle sizes [mpdx-react]

Compared against 348e611

No significant changes found

@caleballdrin caleballdrin changed the title Suggested Tags Fix MPDX-8333 Suggested Tags Fix Oct 3, 2024
dr-bizz
dr-bizz approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I have tested this and it works, but it was also working for me yesterday. This would be great to get Scott to UAT.

@caleballdrin caleballdrin requested a review from canac October 3, 2024 20:53
canac
canac reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things, but this looks really good! I always love it when PRs have more deleted lines than added lines! 🎉

src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.test.tsx Outdated Show resolved Hide resolved
src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.tsx Show resolved Hide resolved
src/components/Layouts/Primary/NavBar/NavItem/NavItem.tsx Show resolved Hide resolved
src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.test.tsx Outdated Show resolved Hide resolved
src/components/Task/Modal/Form/Complete/TaskModalCompleteForm.test.tsx Outdated Show resolved Hide resolved
@caleballdrin caleballdrin requested a review from canac October 4, 2024 05:03
canac
canac approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@canac canac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I tested it and saves the suggested tags to the task.

@caleballdrin caleballdrin merged commit e9331a0 into main Oct 4, 2024
18 checks passed
@caleballdrin caleballdrin deleted the suggested-tags-fix branch October 4, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-bizz dr-bizz dr-bizz approved these changes

@canac canac canac approved these changes

Assignees

@caleballdrin caleballdrin

Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caleballdrin @canac @dr-bizz