Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-Jira] Add link to HelpJuice ticket #1128

Merged
merged 1 commit into from
Oct 10, 2024
Merged

[no-Jira] Add link to HelpJuice ticket #1128

merged 1 commit into from
Oct 10, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Oct 10, 2024

Description

Add a link to the HelpJuice ticket tracking the DOMContentLoaded bug. If it gets resolved in the future, we can switch to loading the beacon with a Next.js <Script>, which will be better for performance.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac requested a review from dr-bizz October 10, 2024 14:59
@canac canac self-assigned this Oct 10, 2024
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against 745daa8

No significant changes found

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! thank you for updating it

@canac canac merged commit 4cced29 into main Oct 10, 2024
17 checks passed
@canac canac deleted the helpjuice-ticket-link branch October 10, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants