Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-Jira] Add link to HelpJuice ticket #1128

Merged
merged 1 commit into from
Oct 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pages/_document.page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@
* defer. This is not ideal for first-load performance and should be
* switched to <Script> as soon as Helpjuice can fix their swifty.js
* script.
* Caleb Cox reached out to HelpJuice on August 30, 2024, and they
* a ticket for the issue on October 10, 2024.
* https://helpjuice.canny.io/feature-requests/p/swifty-swiftyjs-beacon-setup-fails-due-to-domcontentloaded-event-already-fired
*/}
{process.env.HELPJUICE_ORIGIN && (
<script
Expand All @@ -47,7 +50,7 @@
/>
)}
{process.env.HELPJUICE_ORIGIN && (
<script src={`${process.env.HELPJUICE_ORIGIN}/swifty.js`} />

Check warning on line 53 in pages/_document.page.tsx

View workflow job for this annotation

GitHub Actions / eslint

Synchronous scripts should not be used. See: https://nextjs.org/docs/messages/no-sync-scripts
)}
{process.env.DATADOG_CONFIGURED === 'true' && (
<Script id="datadog-rum" strategy="afterInteractive">
Expand Down
Loading