[MPDX-8444] Upgrade yup

package.json

@@ -84,7 +84,7 @@
     "tslib": "^2.4.0",
     "tss-react": "^4.1.3",
     "uuid": "^9.0.0",
-    "yup": "^0.32.11"
+    "yup": "^1.4.0"
   },
   "devDependencies": {
     "@brainly/onesky-utils": "1.4.2",

pages/api/Schema/ContactPrimaryAddress/datahandler.ts

@@ -8,7 +8,10 @@ const getAddressesResponseSchema = object({
     relationships: object({
       addresses: object({
         data: array().of(
-          object({ id: string().required(), type: string().required() }),
+          object({
+            id: string().required(),
+            type: string().required(),
+          }).required(),
         ),
       }).required(),
     }).required(),

src/components/Contacts/ContactDetails/ContactDetailsTab/Mailing/EditMailingInfoModal/EditMailingInfoModal.tsx

@@ -67,7 +67,7 @@ export const EditMailingInfoModal: React.FC<EditMailingInfoModalProps> = ({
   // Add additional language locales here, for multiline TextField support
   const multilineLocales = ['de'];
 
-  const mailingInfoSchema: yup.SchemaOf<
+  const mailingInfoSchema: yup.ObjectSchema<
     Pick<
       ContactUpdateInput,
       'id' | 'greeting' | 'envelopeGreeting' | 'sendNewsletter'

src/components/Contacts/ContactDetails/ContactDetailsTab/Mailing/addressSchema.ts

@@ -28,7 +28,7 @@ export const addressSchema = yup.object({
             address.street,
         ),
     ),
-  primaryMailingAddress: yup.boolean().nullable(false),
+  primaryMailingAddress: yup.boolean().defined(),
 });
 
 export type AddressSchema = yup.InferType<typeof addressSchema>;

src/components/Contacts/ContactDetails/ContactDetailsTab/Other/EditContactOtherModal/EditContactOtherModal.tsx

@@ -173,7 +173,7 @@ export const EditContactOtherModal: React.FC<EditContactOtherModalProps> = ({
         dataFilteredByName?.contacts.nodes ||
         [];
 
-  const contactOtherSchema: yup.SchemaOf<
+  const contactOtherSchema: yup.ObjectSchema<
     Pick<
       ContactUpdateInput,
       | 'id'
@@ -192,7 +192,7 @@ export const EditContactOtherModal: React.FC<EditContactOtherModalProps> = ({
     churchName: yup.string().nullable(),
     preferredContactMethod: yup
       .mixed<PreferredContactMethodEnum>()
-      .oneOf([...Object.values(PreferredContactMethodEnum), null])
+      .oneOf(Object.values(PreferredContactMethodEnum))
       .nullable(),
     locale: yup.string().nullable(),
     timezone: yup.string().nullable(),

src/components/Contacts/ContactDetails/ContactDetailsTab/People/Items/PersonModal/personModalHelper.tsx

@@ -9,7 +9,7 @@ import {
 import { NewSocial, Person } from './PersonModal';
 
 interface GetPersonSchemaReturnedValues {
-  personSchema: yup.SchemaOf<
+  personSchema: yup.ObjectSchema<
     Omit<PersonUpdateInput, 'familyRelationships' | 'id'>
   >;
   initialPerson: (PersonCreateInput | PersonUpdateInput) & NewSocial;
@@ -26,25 +26,27 @@ export const getPersonSchema = (
     title: yup.string().nullable(),
     suffix: yup.string().nullable(),
     phoneNumbers: yup.array().of(
-      yup.object({
-        id: yup.string().nullable(),
-        number: yup.string().when('destroy', {
-          is: true,
-          then: yup.string().nullable(),
-          otherwise: yup
-            .string()
-            .required(t('This field is required'))
-            .nullable()
-            .test(
-              'is-phone-number',
-              t('This field is not a valid phone number'),
-              (val) => typeof val === 'string' && /\d/.test(val),
-            ),
-        }),
-        destroy: yup.boolean().default(false),
-        primary: yup.boolean().default(false),
-        historic: yup.boolean().default(false),
-      }),
+      yup
+        .object({
+          id: yup.string().nullable(),
+          number: yup.string().when('destroy', {
+            is: true,
+            then: (schema) => schema.nullable(),
+            otherwise: (schema) =>
+              schema
+                .required(t('This field is required'))
+                .nullable()
+                .test(
+                  'is-phone-number',
+                  t('This field is not a valid phone number'),
+                  (val) => typeof val === 'string' && /\d/.test(val),
+                ),
+          }),
+          destroy: yup.boolean().default(false),
+          primary: yup.boolean().default(false),
+          historic: yup.boolean().default(false),
+        })
+        .required(),
     ),
     emailAddresses: yup.array().of(
       yup.object({
@@ -59,38 +61,48 @@ export const getPersonSchema = (
       }),
     ),
     facebookAccounts: yup.array().of(
-      yup.object({
-        id: yup.string().nullable(),
-        destroy: yup.boolean().default(false),
-        username: yup.string().required(),
-      }),
+      yup
+        .object({
+          id: yup.string().nullable(),
+          destroy: yup.boolean().default(false),
+          username: yup.string().required(),
+        })
+        .required(),
     ),
     linkedinAccounts: yup.array().of(
-      yup.object({
-        id: yup.string().nullable(),
-        destroy: yup.boolean().default(false),
-        publicUrl: yup.string().required(),
-      }),
+      yup
+        .object({
+          id: yup.string().nullable(),
+          destroy: yup.boolean().default(false),
+          publicUrl: yup.string().required(),
+        })
+        .required(),
     ),
     twitterAccounts: yup.array().of(
-      yup.object({
-        id: yup.string().nullable(),
-        destroy: yup.boolean().default(false),
-        screenName: yup.string().required(),
-      }),
+      yup
+        .object({
+          id: yup.string().nullable(),
+          destroy: yup.boolean().default(false),
+          screenName: yup.string().required(),
+        })
+        .required(),
     ),
     websites: yup.array().of(
-      yup.object({
-        id: yup.string().nullable(),
-        destroy: yup.boolean().default(false),
-        url: yup.string().required(),
-      }),
+      yup
+        .object({
+          id: yup.string().nullable(),
+          destroy: yup.boolean().default(false),
+          url: yup.string().required(),
+        })
+        .required(),
     ),
     newSocials: yup.array().of(
-      yup.object({
-        value: yup.string().required(),
-        type: yup.string().required(),
-      }),
+      yup
+        .object({
+          value: yup.string().required(),
+          type: yup.string().required(),
+        })
+        .required(),
     ),
     optoutEnewsletter: yup.boolean().default(false),
     birthdayDay: yup.number().nullable(),

src/components/Contacts/ContactDetails/ContactDetailsTab/Tags/ContactTags.tsx

@@ -38,7 +38,7 @@ interface ContactTagsProps {
 }
 
 const tagSchema = yup.object({
-  tagList: yup.array().of(yup.string()).default([]),
+  tagList: yup.array().of(yup.string().required()).default([]),
 });
 
 export const ContactTags: React.FC<ContactTagsProps> = ({

src/components/Contacts/ContactDetails/ContactDonationsTab/PartnershipInfo/EditPartnershipInfoModal/EditPartnershipInfoModal.tsx

@@ -87,10 +87,7 @@ const SelectInteractive = styled(Select, {
 
 const contactPartnershipSchema = yup.object({
   id: yup.string().required(),
-  status: yup
-    .mixed<StatusEnum | null>()
-    .oneOf([...Object.values(StatusEnum), null])
-    .nullable(),
+  status: yup.mixed<StatusEnum>().oneOf(Object.values(StatusEnum)).nullable(),
   pledgeAmount: yup.number().moreThan(-1).nullable(),
   pledgeStartDate: nullableDateTime(),
   pledgeReceived: yup.boolean().default(false).nullable(),

src/components/Contacts/MassActions/AddTags/MassActionsAddTagsModal.tsx

@@ -53,7 +53,7 @@ const AddTagIcon = styled(Add)(() => ({
 }));
 
 const tagSchema = yup.object({
-  tagList: yup.array().of(yup.string()).default([]).nullable(),
+  tagList: yup.array().of(yup.string().required()).default([]).nullable(),
 });
 
 export const MassActionsAddTagsModal: React.FC<

src/components/Contacts/MassActions/RemoveTags/MassActionsRemoveTagsModal.tsx

@@ -51,7 +51,7 @@ const RemoveTagIcon = styled(Remove)(() => ({
 }));
 
 const tagSchema = yup.object({
-  tagList: yup.array().of(yup.string()).default([]).nullable(),
+  tagList: yup.array().of(yup.string().required()).default([]).nullable(),
 });
 
 export const MassActionsRemoveTagsModal: React.FC<

src/components/Dashboard/ThisWeek/NewsletterMenu/MenuItems/LogNewsLetter/LogNewsletter.tsx

@@ -81,7 +81,7 @@ const LoadingIndicator = styled(CircularProgress)(({ theme }) => ({
 
 const taskSchema = yup.object({
   activityType: yup
-    .mixed()
+    .mixed<ActivityTypeEnum | 'BOTH'>()
     .oneOf([...Object.values(ActivityTypeEnum), 'BOTH' as const])
     .defined(),
   completedAt: nullableDateTime(),

src/components/Layouts/Primary/TopBar/Items/AddMenu/Items/CreateContact/CreateContact.tsx

@@ -59,7 +59,7 @@ const LoadingIndicator = styled(CircularProgress)(({ theme }) => ({
   margin: theme.spacing(0, 1, 0, 0),
 }));
 
-const contactSchema: yup.SchemaOf<Pick<ContactCreateInput, 'name'>> =
+const contactSchema: yup.ObjectSchema<Pick<ContactCreateInput, 'name'>> =
   yup.object({
     name: yup.string().required(),
   });