Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HS-1262665] Fix addresses with zip codes not showing predictions #1233

Merged
merged 1 commit into from
Dec 19, 2024

Fix addresses with zip codes not showing predictions

4404bd6
Select commit
Loading
Failed to load commit list.
Merged

[HS-1262665] Fix addresses with zip codes not showing predictions #1233

Fix addresses with zip codes not showing predictions
4404bd6
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Dec 18, 2024 in 1m 8s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.01 (9.05 -> 9.05)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method StreetAutocomplete.tsx: StreetAutocomplete:React.FC<StreetAutocompleteProps>

Annotations

Check warning on line 174 in src/components/Contacts/ContactDetails/ContactDetailsTab/Mailing/StreetAutocomplete/StreetAutocomplete.tsx

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

StreetAutocomplete:React.FC<StreetAutocompleteProps> already has high cyclomatic complexity, and now it increases in Lines of Code from 120 to 121. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis