-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no-Jira] Disable Dependabot PRs for non-security updates #1239
Conversation
Bundle sizes [mpdx-react]Compared against 70ada23 No significant changes found |
Yes, I'm all for making less noise if we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I'm out today, I don't want to block you, but I was unsure what the below does and how it is different from CruGlobal/amplify-preview-actions@handle-existing-branches
CruGlobal/amplify-preview-actions@sed-replace-all
@@ -22,7 +22,7 @@ jobs: | |||
role-to-assume: ${{ secrets.AWS_GITHUB_ACTIONS_ROLE }} | |||
output-credentials: true | |||
- name: deploy PR preview | |||
uses: CruGlobal/amplify-preview-actions@handle-existing-branches | |||
uses: CruGlobal/amplify-preview-actions@sed-replace-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the diff. Before it was only replacing the first character that isn't valid in a URL with a dash. Now it replaced all of them. This was code that generates the preview URL comment on the PR. So now the comment will have the right link in Dependabot PRs because those branches contain special characters like / and .
Description
@dr-bizz Let me know if you like those PRs, but I was thinking that we ignore them so they don't add noise and we can focus on Dependabot updates that resolve security vulnerabilities.
Checklist: