Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-Jira] Disable Dependabot PRs for non-security updates #1239

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Dec 19, 2024

Description

@dr-bizz Let me know if you like those PRs, but I was thinking that we ignore them so they don't add noise and we can focus on Dependabot updates that resolve security vulnerabilities.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@canac canac requested a review from dr-bizz December 19, 2024 15:42
@canac canac self-assigned this Dec 19, 2024
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Bundle sizes [mpdx-react]

Compared against 70ada23

No significant changes found

@dr-bizz
Copy link
Contributor

dr-bizz commented Dec 20, 2024

Yes, I'm all for making less noise if we can.

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I'm out today, I don't want to block you, but I was unsure what the below does and how it is different from CruGlobal/amplify-preview-actions@handle-existing-branches

CruGlobal/amplify-preview-actions@sed-replace-all

@@ -22,7 +22,7 @@ jobs:
role-to-assume: ${{ secrets.AWS_GITHUB_ACTIONS_ROLE }}
output-credentials: true
- name: deploy PR preview
uses: CruGlobal/amplify-preview-actions@handle-existing-branches
uses: CruGlobal/amplify-preview-actions@sed-replace-all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the diff. Before it was only replacing the first character that isn't valid in a URL with a dash. Now it replaced all of them. This was code that generates the preview URL comment on the PR. So now the comment will have the right link in Dependabot PRs because those branches contain special characters like / and .

CruGlobal/amplify-preview-actions@handle-existing-branches...CruGlobal:amplify-preview-actions:sed-replace-all

@canac canac merged commit 28026ac into main Dec 20, 2024
20 checks passed
@canac canac deleted the disable-dependabot-version-updates branch December 20, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants