Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-Jira] Disable Dependabot PRs for non-security updates #1239

Merged
merged 3 commits into from
Dec 20, 2024
Merged

[no-Jira] Disable Dependabot PRs for non-security updates #1239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5bc761
Disable Dependabot PRs for non-security updates
canac Dec 19, 2024
e431386
Remove unnecessary config
canac Dec 19, 2024
9a4ee31
Replace all invalid characters with dashes in the Amplify Preview com…
canac Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ updates:
interval: daily
reviewers:
- CruGlobal/web-engineering-js
pull-request-branch-name:
separator: '-'
# Disable version updates while still allowing security updates
open-pull-requests-limit: 0
2 changes: 1 addition & 1 deletion .github/workflows/preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
role-to-assume: ${{ secrets.AWS_GITHUB_ACTIONS_ROLE }}
output-credentials: true
- name: deploy PR preview
uses: CruGlobal/amplify-preview-actions@handle-existing-branches
uses: CruGlobal/amplify-preview-actions@sed-replace-all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the diff. Before it was only replacing the first character that isn't valid in a URL with a dash. Now it replaced all of them. This was code that generates the preview URL comment on the PR. So now the comment will have the right link in Dependabot PRs because those branches contain special characters like / and .

CruGlobal/amplify-preview-actions@handle-existing-branches...CruGlobal:amplify-preview-actions:sed-replace-all

with:
branch_name: ${{ github.head_ref }}
amplify_command: deploy
Expand Down
Loading