Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpscout - Fixing blank screen error on contact details #961

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Jun 19, 2024

Description

This pull request addresses the issue of a blank screen appearing on the contact details tab within a contact.

The problem stems from a date format function called dateFromParts. This function lacks the capability to handle an invalid date, resulting in an error when attempting to convert it into a date.

I resolved this issue by implementing error handling within the function and included a test to verify the correct functionality of the fix.

Checklist:

  • I have given my PR a title with the format "MPDX-(JIRA#) (summary sentence max 80 chars)"
  • I have applied the appropriate labels. (Add the label "On Staging" to get the branch automatically merged into staging.)
  • I have requested a review from another person on the project

@dr-bizz dr-bizz requested a review from caleballdrin June 19, 2024 17:31
Copy link
Contributor

Bundle sizes [mpdx-react]

Compared against deafe90

No significant changes found

@dr-bizz dr-bizz force-pushed the blank-page-on-bad-data branch from 2daf37c to 64f3bd9 Compare June 19, 2024 17:33
@dr-bizz dr-bizz added the Preview Environment Add this label to create an Amplify Preview label Jun 19, 2024
Copy link
Contributor

Preview branch generated at https://blank-page-on-bad-data.d3dytjb8adxkk5.amplifyapp.com

Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dr-bizz dr-bizz merged commit f58d594 into main Jun 19, 2024
20 checks passed
@dr-bizz dr-bizz deleted the blank-page-on-bad-data branch June 19, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview Environment Add this label to create an Amplify Preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants