Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamingDataset and MutableDataset have now deprecated warning messa… #376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mathiasbc
Copy link
Contributor

…ges. They still exists but their behaviour is directly inherited from the Dataset class, which makes them identical at this point

…ges. They still exists but their behaviour is directly inherited from the Dataset class, which makes them identical at this point
@jamesrkg
Copy link

jamesrkg commented Nov 15, 2019

How does the scrunch.dataset.LOG work? We also use a logger but the deprecation warning is not coming up. It might be better to raise a DeprecationWarning in a simpler way to ensure its visible to all users, in addition to sending it to your logger.

@jamesrkg
Copy link

I think Dataset would benefit from:

@property
def streaming(self):
    return self.resource.body.get('streaming', 'no')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants