Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the index provided by SortedView to filters #22

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

hadashiA
Copy link
Contributor

@hadashiA hadashiA commented Feb 2, 2024

I would like to change the value of the index that a filter attached to a SortedView gets.
( This is a breaking change.)

Before

  • SortedView notify the index value of the source (IObservableCollection).

After

  • SortedView notify the index after sorting.

@@ -49,7 +49,7 @@ public CloneCollection(IEnumerable<T> source)
}
else
{
var array = ArrayPool<T>.Shared.Rent(count);
var array = ArrayPool<T>.Shared.Rent(16);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

( This diff is probably due to the file being synced to the Unity side.

@neuecc neuecc merged commit 2d35d94 into master Feb 15, 2024
2 checks passed
@neuecc neuecc deleted the hadashiA/sorted-index branch February 15, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants