Sort qualifications by type and date #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
force-pushed
the
143-update-teacher-record-row-ordering
branch
2 times, most recently
from
d59ad9a to
f460f96
Compare
steventux
force-pushed
the
143-update-teacher-record-row-ordering
branch
from
f460f96 to
18763e3
Compare
steventux
force-pushed
the
143-update-teacher-record-row-ordering
branch
from
70ca043 to
3241fa3
Compare
malcolmbaig
reviewed
Nov 15, 2023
| add_npq | ||
| add_mandatory_qualifications |
There was a problem hiding this comment.
Given we can have multiple mandatory qualifications returned, do we need explicit ordering by awarded, as we do for NPQ?
There was a problem hiding this comment.
Good spot, I hadn't noticed these could be multiples, have applied the same date sorting as others now.
|
Review app deployed to https://s165d01-aytq-review-pr-423-app.azurewebsites.net |
Sorts qualifications by their type according to the typical career progression of a teacher. ie. NPQ or MQ | Induction | QTS | ITT (for QTS) | EYTS | ITT (for EYTS) | Mandatory | HE This produces a consistent order for the types of qualification starting with the most recent. In the case of a specific type of qualification having multiple results, the qualifications are sorted by reverse chronological awarded at date.
The quality of this data is not great, we've decided to exclude these qualifications.
steventux
force-pushed
the
143-update-teacher-record-row-ordering
branch
from
3241fa3 to
0fb9bf1
Compare
malcolmbaig
approved these changes
Nov 16, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We’re currently combining all of the teacher qualifications and sorting by date awarded.
This is leading to some inconsistent ordering between records.
A consistent order by qualification type, then awarded at date is preferrable.
Changes proposed in this pull request
Sorts qualifications by their type according to the typical career
progression of a teacher.
ie.
NPQ or MQ | Induction | QTS | ITT (for QTS) | EYTS | ITT (for EYTS)This produces a consistent order for the types of qualification starting
with the most recent.
In the case of a specific type of qualification having multiple results,
the qualifications are sorted by reverse chronological awarded at date.
Guidance to review
Link to Trello card
https://trello.com/c/auIQPskM/143-update-teacher-record-row-ordering
Checklist