Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2315] Add migration to set decline by default #9875

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

elceebee
Copy link
Contributor

Context

This is the second of three PRs to correct this bug related to decline_by_default. See the first PR here for context and to see what has been done already.

Changes proposed in this pull request

Job will set data to nil for about 40,109 applications. See blazer query.

I've tested it locally with 4000 application choices and it took 6.506ms, so I think this update will only take 65ms, no time at all.

Guidance to review

Will this touch 40,000 records? Am going to cause another BIG TOUCH incident? I don't think so because it doesn't execute active record callbacks, but if someone knows better, please speak up!

https://apidock.com/rails/ActiveRecord/Relation/update_all

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Add PR link to Trello card

@elceebee elceebee added the deploy_v2 Deploy the review app to AKS label Sep 26, 2024
@github-actions github-actions bot temporarily deployed to review_aks-9875 September 26, 2024 10:52 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-9875 September 26, 2024 11:03 Destroyed
@elceebee elceebee changed the title Add migration to set decline by default [2315] Add migration to set decline by default Sep 26, 2024
@elceebee elceebee marked this pull request as ready for review September 26, 2024 12:28
@elceebee elceebee merged commit b1480d1 into main Sep 26, 2024
116 of 118 checks passed
@elceebee elceebee deleted the pr2-2315-remove-default-by-default-at-column branch September 26, 2024 12:35
@elceebee
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants