Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slack failure notification to the deploy workflow #1048

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Add slack failure notification to the deploy workflow #1048

merged 1 commit into from
Mar 5, 2024
+51 −4

Conversation

johnake
Copy link
Contributor

@johnake johnake commented Mar 5, 2024 •
edited
Loading

Context

A pipeline failure was picked up recently - there was no slack notification set up for this pipeline.
We need to add slack notifications for failures so that such issues are picked up quickly

Changes proposed in this pull request

Add slack notification to build-and-deploy workflow

Guidance to review

Notification successfully tested:

image

Link to Trello card

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@johnake johnake requested a review from a team as a code owner March 5, 2024 10:24
@johnake johnake added the deploy label Mar 5, 2024
@johnake johnake temporarily deployed to preproduction March 5, 2024 10:27 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

AKS review app deployed to https://find-a-lost-trn-review-pr-1048.test.teacherservices.cloud

@johnake johnake requested a deployment to review March 5, 2024 10:37 — with GitHub Actions Abandoned
@johnake johnake requested a deployment to preproduction March 5, 2024 10:37 — with GitHub Actions Abandoned
@johnake johnake requested a deployment to test March 5, 2024 10:37 — with GitHub Actions Abandoned
@johnake johnake requested a deployment to review March 5, 2024 10:42 — with GitHub Actions Abandoned
@johnake johnake requested a deployment to preproduction March 5, 2024 10:42 — with GitHub Actions Abandoned
@johnake johnake requested a deployment to test March 5, 2024 10:42 — with GitHub Actions Abandoned
@johnake johnake requested a deployment to review March 5, 2024 10:49 — with GitHub Actions Abandoned
@johnake johnake requested a deployment to preproduction March 5, 2024 10:49 — with GitHub Actions Abandoned
@johnake johnake requested a deployment to test March 5, 2024 10:49 — with GitHub Actions Abandoned
@johnake johnake requested a deployment to review March 5, 2024 10:52 — with GitHub Actions Abandoned
@johnake johnake requested a deployment to test March 5, 2024 10:52 — with GitHub Actions Abandoned
@johnake johnake requested a deployment to preproduction March 5, 2024 10:52 — with GitHub Actions Abandoned
@johnake johnake requested a deployment to review March 5, 2024 10:55 — with GitHub Actions Abandoned
@johnake johnake requested a deployment to test March 5, 2024 10:55 — with GitHub Actions Abandoned
@johnake johnake requested a deployment to preproduction March 5, 2024 10:55 — with GitHub Actions Abandoned
@johnake johnake changed the title WIP: 1636 faltrn add slack failure notification to the deploy workflow 1636 faltrn add slack failure notification to the deploy workflow Mar 5, 2024
@johnake
Copy link
Contributor Author

johnake commented Mar 5, 2024

FALTRN: Add slack failure notification to the deploy workflow

@johnake johnake force-pushed the 1636-faltrn-add-slack-failure-notification-to-the-deploy-workflow branch from c05d16e to 5712f97 Compare March 5, 2024 12:32
@malcolmbaig malcolmbaig changed the title 1636 faltrn add slack failure notification to the deploy workflow Add slack failure notification to the deploy workflow Mar 5, 2024
@malcolmbaig malcolmbaig mentioned this pull request Mar 5, 2024
Closed
4 tasks
malcolmbaig
malcolmbaig reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@malcolmbaig malcolmbaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for picking this up 👍🏼

One comment from me about the SLACK_COLOR setting, but otherwise LG.

@johnake johnake force-pushed the 1636-faltrn-add-slack-failure-notification-to-the-deploy-workflow branch from b51b781 to 0af551e Compare March 5, 2024 15:58
@johnake johnake merged commit 1e984ec into main Mar 5, 2024
12 checks passed
@johnake johnake deleted the 1636-faltrn-add-slack-failure-notification-to-the-deploy-workflow branch March 5, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malcolmbaig malcolmbaig malcolmbaig left review comments

@saliceti saliceti saliceti approved these changes

Assignees
No one assigned
Labels
deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnake @malcolmbaig @saliceti