Set enable monitoring to true for postgres and redis #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temitope777
suggested changes
Apr 30, 2024
| @@ -2,7 +2,7 @@ | |||
| "app_environment": "production", | |||
| "cluster": "production", | |||
| "file_environment": "prod", | |||
| "enable_monitoring": false, | |||
| "enable_monitoring": true, | |||
There was a problem hiding this comment.
in variables.tf enable_monitoring should default to false and then remove from "enable_monitoring": false, from test.tfvars.json, preproduction.tfvars.json, and development.tfvars.json,
johnake
force-pushed
the
1734-find-a-lost-trn-enable-postgres-monitoring
branch
from
37731bd to
3deacbe
Compare
temitope777
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We should monitor the database in production. Set the setting to true.
This may require creating the action group as per the terraform-modules doc
Changes proposed in this pull request
Checklist