Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set enable monitoring to true for postgres and redis #1069

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Set enable monitoring to true for postgres and redis #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions terraform/aks/.terraform.lock.hcl
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion terraform/aks/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ variable "deploy_azure_backing_services" {

variable "enable_monitoring" {
type = bool
default = true
default = false
description = "Enable monitoring and alerting"
}

Expand Down
1 change: 0 additions & 1 deletion terraform/aks/workspace_variables/development.tfvars.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"app_environment": "development",
"cluster": "test",
"file_environment": "dev",
"enable_monitoring": false,
"namespace": "tra-development",
"azure_resource_prefix": "s189t01",
"config_short": "dv",
Expand Down
1 change: 0 additions & 1 deletion terraform/aks/workspace_variables/preproduction.tfvars.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"app_environment": "preproduction",
"cluster": "test",
"enable_monitoring": false,
"file_environment": "preprod",
"namespace": "tra-test",
"azure_resource_prefix": "s189t01",
Expand Down
2 changes: 1 addition & 1 deletion terraform/aks/workspace_variables/production.tfvars.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"app_environment": "production",
"cluster": "production",
"file_environment": "prod",
"enable_monitoring": false,
"enable_monitoring": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in variables.tf enable_monitoring should default to false and then remove from "enable_monitoring": false, from test.tfvars.json, preproduction.tfvars.json, and development.tfvars.json,

"namespace": "tra-production",
"azure_resource_prefix": "s189p01",
"config_short": "pd",
Expand Down
1 change: 0 additions & 1 deletion terraform/aks/workspace_variables/review.tfvars.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"app_environment": "review",
"cluster": "test",
"file_environment": "review",
"enable_monitoring": false,
"namespace": "tra-development",
"azure_resource_prefix": "s189t01",
"config_short": "rv",
Expand Down
1 change: 0 additions & 1 deletion terraform/aks/workspace_variables/test.tfvars.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"app_environment": "test",
"cluster": "test",
"file_environment": "test",
"enable_monitoring": false,
"namespace": "tra-test",
"azure_resource_prefix": "s189t01",
"config_short": "ts",
Expand Down
Loading