Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag for the API summary content change #4643

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Add feature flag for the API summary content change #4643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/settings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ feedback:
link: https://forms.office.com/pages/responsepage.aspx?id=yXfS-grGoU2187O4s0qC-SKECobyE75EtuJMp8rYxZtURTNaTTJaTVhBQlQzM1RESTJDVlBERk1JQS4u

features:
api_summary_content_change: false
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you ask why a feature flag for a content change on the API?

Thousands of courses will be updated in Apply (confirmed already in the DB) and maybe on Register too.

So I optin for the feature flag approach (see PR description for more info on the plan).

for you awareness @Nitemaeric

send_request_data_to_bigquery: false
rollover:
# Normally a short period of time between rollover and the next cycle
Expand Down
Loading