Add feature flag for the API summary content change #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be default to false as default. Plan: Merge the add feature flag PR Merge the code that uses the feature flag Turn on the feature flag on QA when having a session with Register & Apply (needs a deployment) Have the Register & Apply sign off that everything worked Turn on the feature flag on Production (needs a deployment)
tomas-stefano
commented
Oct 31, 2024
| @@ -89,6 +89,7 @@ feedback: | |||
| link: https://forms.office.com/pages/responsepage.aspx?id=yXfS-grGoU2187O4s0qC-SKECobyE75EtuJMp8rYxZtURTNaTTJaTVhBQlQzM1RESTJDVlBERk1JQS4u | |||
|
|
|||
| features: | |||
| api_summary_content_change: false | |||
There was a problem hiding this comment.
If you ask why a feature flag for a content change on the API?
Thousands of courses will be updated in Apply (confirmed already in the DB) and maybe on Register too.
So I optin for the feature flag approach (see PR description for more info on the plan).
for you awareness @Nitemaeric
6 tasks
Nitemaeric
approved these changes
Nov 4, 2024
tomas-stefano
deleted the
td/33-replace-instances-of-pgde-with-qts-to-qts-with-pgde
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There is inconsistency of terminology between GiT and Find. GiT use “QTS with PGDE” (which is more clear/intuitive) whereas Find uses “PGDE with QTS”.
It was decided by Apply and Find teach leads to change the API content of the course description to the expected ones (PGCE with QTS becomes QTS with PGCE and PGDE with QTS becomes QTS with PGDE).
This is a simple PR that just adds the feature flag.
Will be
falseas default in all environments.Plan