Replace instances of PGDE with QTS / change API course summary #4645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomas-stefano
force-pushed
the
td/33-replace-instances-of-pgde-with-qts-changes
branch
2 times, most recently
from
f0c013f to
d6b407e
Compare
tomas-stefano
commented
Nov 4, 2024
| <% when "QTS" %> | ||
| <%= govuk_details(summary_text: "QTS") do %> | ||
| <% case course.qualification %> | ||
| <% when 'qts' %> |
There was a problem hiding this comment.
I changed the way it was done slightly.
Before: it was using the translation to do a case for another translation.
After: Passing the course qualification and then translate.
I thought to split into partials but then I rollback because the code will be something like:
View -> Component -> Another component -> Multiple partials
tomas-stefano
commented
Nov 4, 2024
| @@ -516,11 +516,20 @@ def program_type_description | |||
| def description | |||
| return qualifications_description if teacher_degree_apprenticeship? | |||
|
|
|||
| study_mode_string = (full_time_or_part_time? ? ', ' : ' ') + | |||
| study_mode_description | |||
| qualifications_description + study_mode_string + program_type_description | |||
| end | |||
There was a problem hiding this comment.
I know the summary above is almost a duplication of this description but my plan is to remove this description field after the feature flag is removed.
tomas-stefano
added a commit
that referenced
this pull request
Nov 5, 2024
tomas-stefano
added a commit
that referenced
this pull request
Nov 5, 2024
This is done behind a feature flag. The course.description and qualifications_description will be deleted when we cleanup the feature flag after the feature flag is enable in production.
Talked with content designer and we agreed to change these places to follow the pattern QTS with PGDE
tomas-stefano
force-pushed
the
td/33-replace-instances-of-pgde-with-qts-changes
branch
from
d6b407e to
c5f8792
Compare
tomas-stefano
deleted the
td/33-replace-instances-of-pgde-with-qts-changes
branch
tomas-stefano
added a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There is inconsistency of terminology between GiT and Find. GiT use “QTS with PGDE” (which is more clear/intuitive) whereas Find uses “PGDE with QTS”.
Changes
This PR replaces all instances of
PGDE with QTStoQTS with PGDE.Coordination between other teams
It was decided by Apply and Find teach leads to change the API content of the course description to the expected ones
In order to coordinate this change with this other team this PR:
course.summaryfield in the API.So this is the plan to deploy this: