Moj multi upload #7448
Open
Moj multi upload #7448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starswan
force-pushed
the
moj-multi-upload
branch
from
9cbdb30 to
d86ce30
Compare
|
Review app deployed to https://teaching-vacancies-review-pr-7448.test.teacherservices.cloud on AKS |
starswan
force-pushed
the
moj-multi-upload
branch
from
8e0b981 to
68da99e
Compare
ddippolito
reviewed
Jan 29, 2025
| @@ -69,3 +69,15 @@ Rails.start(); | |||
| govukFrontend.initAll(); | |||
| window.$ = $; | |||
| mojFrontend.initAll(); | |||
|
|
|||
| if (typeof mojFrontend.MultiFileUpload !== 'undefined') { | |||
There was a problem hiding this comment.
Are we sure this is the right place?
Could we add a multifile_upload.js or add it to utils.js?
There was a problem hiding this comment.
not sure - it ought to be in the MoJ library init...
ddippolito
reviewed
Jan 29, 2025
| @@ -1,6 +1,5 @@ | |||
| class Publishers::JobListing::DocumentsForm < Publishers::JobListing::VacancyForm | |||
| validates :supporting_documents, form_file: DOCUMENT_VALIDATION_OPTIONS | |||
| validate :document_presence | |||
| validates :supporting_documents, presence: true, if: -> { vacancy.include_additional_documents } | |||
ddippolito
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/2jvmL1ZP/1458-change-to-moj-document-upload-component-for-uploading-additional-documents
Changes in this PR:
Use MoJ multi-file upload for additional document upload
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?