Add icon for coming notes feature
#4905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
reviewed
Sep 3, 2024
data/art/note-green-pin.png
Outdated
There was a problem hiding this comment.
could you rename this file green_pin_map.png? we're trying to give assets intended for the map layer a _map.png suffix.
There was a problem hiding this comment.
I can, but I have doubts about generality of the name.
green_pin_map.png suggest that other tool can use it on the map - but in reality other tools would probably need its own version with the pin placed in different relative position to the tile.
There was a problem hiding this comment.
as long as it has the _map suffix, it's fine. note_green_pin_map.png would be ok too
myk002
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add icon for coming
notesfeature.Needed for DFHack/scripts#1287