Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon for coming notes feature #4905

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Add icon for coming notes feature #4905

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ba6147
Add icon for coming `notes` feature
wiktor-obrebski Sep 3, 2024
244fadb
Standarize note map tile image name
wiktor-obrebski Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added data/art/note-green-pin.png
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you rename this file green_pin_map.png? we're trying to give assets intended for the map layer a _map.png suffix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can, but I have doubts about generality of the name.
green_pin_map.png suggest that other tool can use it on the map - but in reality other tools would probably need its own version with the pin placed in different relative position to the tile.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as long as it has the _map suffix, it's fine. note_green_pin_map.png would be ok too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.