Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Faith Description Edits #780

Merged
merged 7 commits into from
Oct 1, 2024

Conversation

lavillastrangiato
Copy link
Contributor

@lavillastrangiato lavillastrangiato commented Sep 22, 2024

About The Pull Request

  • Removes Psydon's name from Astrata and Noc's descriptions.
  • Removes mention that Dendor is Psydon's son???
  • Generally cleans up the descriptions, fixing typos and grammar errors.
  • Fixes a single typo on Noc's amulet description.
  • On some of the descriptions the things the gods hate or appreciate are slightly edited. Please feel free to complain about them even if you think they are small changes. I accept that these do change vibes slightly.

Why It's Good For The Game

Just makes things a little neater.

Pre-Merge Checklist

  • You tested this on a local server.
  • This code did not runtime during testing.
  • You documented all of your changes.

@Mogelix
Copy link

Mogelix commented Sep 23, 2024

Dendor shouldn't be "steward" of the seas. He's not a clerk or accountant, he is the one who hurls a massive wave at a fisher boat to swallow it whole when its haul is desperately needed in a starving village because they took his boons in the sea for granted.

I would personally like to see the forgotten god decapitalized in all references, as a kind of diminutive term used purposefully to diminish his significance... the Saviour, the Great Hero, the Creator, the All-Father, (and Psydon) these should be the appellations of his own faithful for him- and one of those should be what the 'Psydon' patron is called. The weeper should be somewhere in-between. This is just my personal head canon though.

Otherwise, excellent de-slopification and higher-standard writing.

@lavillastrangiato
Copy link
Contributor Author

lavillastrangiato commented Sep 25, 2024

@Mogelix A steward is not just a clerk, they're keeper or manager of something. They can also keep/manage something in stead of another, which might make acolytes of Abyssor better-suited to be "stewards of the seas".

The other reason I chose that word is for alliteration value. There are, however, other words I could see how they sound; swayer, sovereign, etc.

With regards to Psydon's title, I get your gripe, but I'd personally prefer to have Forgotten God be capitalized as it's a proper noun referring to a specific individual. There's not a "god that was forgotten", There's a singular, specific Forgotten God.

@NPC1314 NPC1314 added the Merge conflict This PR won't compile due to merge conflics label Sep 26, 2024
@NPC1314 NPC1314 added Scheduled for testmerge This PR should be testmerged and removed Merge conflict This PR won't compile due to merge conflics labels Sep 30, 2024
Copy link
Contributor

@Optimism333 Optimism333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like decent description updates overall! Don't have any problems giving it approval.

@NPC1314 NPC1314 removed the Scheduled for testmerge This PR should be testmerged label Oct 1, 2024
@NPC1314 NPC1314 merged commit 144115b into Darkrp-community:main Oct 1, 2024
3 checks passed
@lavillastrangiato lavillastrangiato deleted the faithfixes branch October 2, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants