Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faq: add-sdwire-faq-section #712

Merged
merged 4 commits into from
Nov 23, 2023
Merged

faq: add-sdwire-faq-section #712

merged 4 commits into from
Nov 23, 2023

Conversation

Stanislaw-bnk
Copy link
Contributor

No description provided.

@Stanislaw-bnk Stanislaw-bnk self-assigned this Nov 22, 2023
pietrushnic
pietrushnic requested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@pietrushnic pietrushnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also have a place where we can gather feature requests. @macpijan what do you think is dasharo-issues or OSFV, or maybe https://github.com/3mdeb/SDWire good place to gather feature requests?

@rafkoch we need roadmap focused approach to evolution of this product.

@Stanislaw-bnk
Copy link
Contributor Author

Stanislaw-bnk commented Nov 23, 2023 •
edited
Loading

The pre-commit with the latest fix show errors.
The reason is too long heading. How can I easily break/wrap the heading?
Screenshot from 2023-11-23 10-40-22
Alt+Q / Shift+enter doesn't seem to work here. @artur-rs cc

@pietrushnic
Copy link
Contributor

@Stanislaw-bnk The fact you have so long time is a problem in itself, you should shorten that question. Last resort you can disable checks per line. Example: https://github.com/Dasharo/docs/blob/master/docs/osf-trivia-list/dasharo.md?plain=1#L339

@Stanislaw-bnk
Copy link
Contributor Author

fixed in 962058d

@pietrushnic pietrushnic merged commit 58276dd into master Nov 23, 2023
3 checks passed
@pietrushnic pietrushnic deleted the sdwire-faq branch November 23, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietrushnic pietrushnic pietrushnic approved these changes

@macpijan macpijan Awaiting requested review from macpijan

Assignees

@Stanislaw-bnk Stanislaw-bnk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stanislaw-bnk @pietrushnic