Adopt mypy (#6821, #4558) #6822

hannes-ucsc · 2025-01-13T18:09:45Z

Connected issues: #6821, #4558

Checklist

Author

PR is a draft
Target branch is develop
Name of PR branch matches issues/<GitHub handle of author>/<issue#>-<slug>
On ZenHub, PR is connected to all issues it (partially) resolves
PR description links to connected issues
PR title matches¹ that of a connected issue _{or comment in PR explains why they're different}
PR title references all connected issues
For each connected issue, there is at least one commit whose title references that issue

¹ when the issue title describes a problem, the corresponding PR
title is Fix: followed by the issue title

Author (partiality)

Added p tag to titles of partial commits
This PR is labeled partial _{or completely resolves all connected issues}
~~This PR partially resolves each of the connected issues _{or does not have the partial label}~~

Author (chains)

This PR is blocked by previous PR in the chain _{or is not chained to another PR}
The blocking PR is labeled base _{or this PR is not chained to another PR}
This PR is labeled chained _{or is not chained to another PR}

Author (reindex, API changes)

Added r tag to commit title _{or the changes introduced by this PR will not require reindexing of any deployment}
This PR is labeled reindex:dev _{or the changes introduced by it will not require reindexing of dev}
This PR is labeled reindex:anvildev _{or the changes introduced by it will not require reindexing of anvildev}
This PR is labeled reindex:anvilprod _{or the changes introduced by it will not require reindexing of anvilprod}
This PR is labeled reindex:prod _{or the changes introduced by it will not require reindexing of prod}
This PR is labeled reindex:partial and its description documents the specific reindexing procedure for dev, anvildev, anvilprod and prod _{or requires a full reindex or carries none of the labels reindex:dev, reindex:anvildev, reindex:anvilprod and reindex:prod}
This PR and its connected issues are labeled API _{or this PR does not modify a REST API}
Added a (A) tag to commit title for backwards (in)compatible changes _{or this PR does not modify a REST API}
Updated REST API version number in app.py _{or this PR does not modify a REST API}

Author (upgrading deployments)

Ran make docker_images.json and committed the resulting changes _{or this PR does not modify azul_docker_images, or any other variables referenced in the definition of that variable}
Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading deployments}
Added u tag to commit title _{or this PR does not require upgrading deployments}
This PR is labeled upgrade _{or does not require upgrading deployments}
This PR is labeled deploy:shared _{or does not modify docker_images.json, and does not require deploying the shared component for any other reason}
This PR is labeled deploy:gitlab _{or does not require deploying the gitlab component}
This PR is labeled deploy:runner _{or does not require deploying the runner image}

Author (hotfixes)

Added F tag to main commit title _{or this PR does not include permanent fix for a temporary hotfix}
Reverted the temporary hotfixes for any connected issues _{or the none of the stable branches (anvilprod and prod) have temporary hotfixes for any of the issues connected to this PR}

Author (before every review)

Rebased PR branch on develop, squashed old fixups
Ran make requirements_update _{or this PR does not modify requirements*.txt, common.mk, Makefile and Dockerfile}
Added R tag to commit title _{or this PR does not modify requirements*.txt}
This PR is labeled reqs _{or does not modify requirements*.txt}
make integration_test passes in personal deployment _{or this PR does not modify functionality that could affect the IT outcome}

Peer reviewer (after approval)

PR is not a draft
Ticket is in Review requested column
PR is awaiting requested review from system administrator
PR is assigned to only the system administrator

System administrator (after approval)

Actually approved the PR
Labeled connected issues as demo or no demo
Commented on connected issues about demo expectations _{or all connected issues are labeled no demo}
Decided if PR can be labeled no sandbox
A comment to this PR details the completed security design review
PR title is appropriate as title of merge commit
N reviews label is accurate
Moved connected issues to Approved column
PR is assigned to only the operator

Operator (before pushing merge the commit)

System administrator

Background migrations for dev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
Background migrations for anvildev.gitlab are complete _{or this PR is not labeled deploy:gitlab}
PR is assigned to only the operator

Operator (before pushing merge the commit)

Operator (chain shortening)

Changed the target branch of the blocked PR to develop _{or this PR is not labeled base}
Removed the chained label from the blocked PR _{or this PR is not labeled base}
Removed the blocking relationship from the blocked PR _{or this PR is not labeled base}
Removed the base label from this PR _{or this PR is not labeled base}

Operator (after pushing the merge commit)

Operator (reindex)

Operator

Propagated the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels to the next promotion PRs _{or this PR carries none of these labels}
Propagated any specific instructions related to the deploy:shared, deploy:gitlab, deploy:runner, API, reindex:partial, reindex:anvilprod and reindex:prod labels, from the description of this PR to that of the next promotion PRs _{or this PR carries none of these labels}
PR is assigned to no one

Shorthand for review comments

L line is too long
W line wrapping is wrong
Q bad quotes
F other formatting problem

src/azul/collections.py

src/azul/openapi/schema.py

src/azul/__init__.py

src/azul/types.py

coveralls · 2025-01-20T06:44:38Z

coverage: 85.636% (-0.03%) from 85.664%
when pulling 4c6e088 on issues/hannes-ucsc/6821-mypy-1
into 9a48715 on develop.

codecov · 2025-01-20T07:07:17Z

Codecov Report

Attention: Patch coverage is 93.97590% with 15 lines in your changes missing coverage. Please review.

Project coverage is 85.61%. Comparing base (9a48715) to head (4c6e088).
Report is 25 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/azul/types.py	80.64%	12 Missing ⚠️
src/azul/azulclient.py	90.90%	1 Missing ⚠️
src/azul/chalice.py	96.15%	1 Missing ⚠️
src/azul/openapi/schema.py	98.11%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6822      +/-   ##
===========================================
- Coverage    85.64%   85.61%   -0.03%     
===========================================
  Files          149      149              
  Lines        21006    21034      +28     
===========================================
+ Hits         17991    18009      +18     
- Misses        3015     3025      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…st (#4558)

hannes-ucsc · 2025-01-20T23:18:40Z

Security design review

github-actions bot added the orange [process] Done by the Azul team label Jan 13, 2025

github-advanced-security bot found potential problems Jan 13, 2025

View reviewed changes

src/azul/collections.py Dismissed Show dismissed Hide dismissed

src/azul/collections.py Dismissed Show dismissed Hide dismissed

hannes-ucsc closed this Jan 16, 2025

hannes-ucsc force-pushed the issues/hannes-ucsc/6821-mypy-1 branch from e0a9227 to 8e2ecb3 Compare January 16, 2025 07:24

hannes-ucsc reopened this Jan 16, 2025

github-advanced-security bot found potential problems Jan 16, 2025

View reviewed changes

src/azul/openapi/schema.py Fixed Show fixed Hide fixed

src/azul/openapi/schema.py Fixed Show fixed Hide fixed

hannes-ucsc force-pushed the issues/hannes-ucsc/6821-mypy-1 branch 2 times, most recently from c717577 to f0d75f8 Compare January 19, 2025 23:44

github-advanced-security bot found potential problems Jan 19, 2025

View reviewed changes

src/azul/__init__.py Fixed Show fixed Hide fixed

src/azul/__init__.py Fixed Show fixed Hide fixed

src/azul/types.py Fixed Show fixed Hide fixed

src/azul/types.py Fixed Show fixed Hide fixed

hannes-ucsc force-pushed the issues/hannes-ucsc/6821-mypy-1 branch from c2bc890 to 6ccf4ea Compare January 20, 2025 06:16

hannes-ucsc force-pushed the issues/hannes-ucsc/6821-mypy-1 branch from e853333 to 6ccf4ea Compare January 20, 2025 07:18

hannes-ucsc added 17 commits January 20, 2025 11:28

[R p] Cover azul.types with mypy (#6821)

c562c66

Add one use of Self

5413cee

[p] Cover azul.collection with mypy (#6821)

4eed103

[p] Cover azul.args and azul.attrs with mypy (#6821)

b181584

[p] Cover azul.auth with mypy (#6821)

76ad657

[p] Cover azul.azulclient with mypy (#6821)

51ada98

[p] Cover azul.openapi with mypy (#6821)

4236d43

Rename schema.TYPE to schema.Form

79fc84d

Rename schema.make_type to schema.make and schema.schema

5b9b0b9

Rename schema.in_range to schema.range

49c9221

Rename schema.with_default to schema.default

8330b62

Inline schema.properties()

f244f5f

Unify schema.object and schema.object_type

d287d88

Replace Union and Optional

0b70af5

Make some assertions requirements

80456cc

Add overloads for azul.open_resource

759899d

Fix bug in MutableCompositeJSON

21c2d5d

hannes-ucsc added 7 commits January 20, 2025 11:31

Rearrange JSON types; extract type alias for JSON arrays

23cd3c7

Cosmetics

441b565

Rename method_spec to spec

355ac77

Reorder method args

6cbbfd5

[R] Fix: AttributeError for Chalice.lambda_context and .current_reque…

8c526f9

…st (#4558)

Simplify indexer action enum

9d8c4bb

[R p] Cover azul.chalice with mypy (#6821)

4c6e088

hannes-ucsc force-pushed the issues/hannes-ucsc/6821-mypy-1 branch from e1b3771 to c562c66 Compare January 20, 2025 19:43

hannes-ucsc changed the title ~~Adopt mypy (#6821)~~ Adopt mypy (#6821, #4558) Jan 20, 2025

hannes-ucsc added partial [process] PR is does not completely resolve associated ticket reqs [process] PR includes commit requiring ``make requirements`` labels Jan 20, 2025

hannes-ucsc added the sandbox [process] Resolution is being verified in sandbox deployment label Jan 20, 2025

hannes-ucsc merged commit cdc508d into develop Jan 20, 2025
11 checks passed

hannes-ucsc assigned achave11-ucsc Jan 20, 2025

achave11-ucsc deleted the issues/hannes-ucsc/6821-mypy-1 branch January 21, 2025 19:28

achave11-ucsc removed their assignment Jan 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adopt mypy (#6821, #4558) #6822

Adopt mypy (#6821, #4558) #6822

hannes-ucsc commented Jan 13, 2025 •

edited by achave11-ucsc

Loading

coveralls commented Jan 20, 2025 •

edited

Loading

codecov bot commented Jan 20, 2025 •

edited

Loading

hannes-ucsc commented Jan 20, 2025

Adopt mypy (#6821, #4558) #6822

Adopt mypy (#6821, #4558) #6822

Conversation

hannes-ucsc commented Jan 13, 2025 • edited by achave11-ucsc Loading

Checklist

Author

Author (partiality)

Author (chains)

Author (reindex, API changes)

Author (upgrading deployments)

Author (hotfixes)

Author (before every review)

Peer reviewer (after approval)

System administrator (after approval)

Operator (before pushing merge the commit)

System administrator

Operator (before pushing merge the commit)

Operator (chain shortening)

Operator (after pushing the merge commit)

Operator (reindex)

Operator

Shorthand for review comments

coveralls commented Jan 20, 2025 • edited Loading

codecov bot commented Jan 20, 2025 • edited Loading

Codecov Report

hannes-ucsc commented Jan 20, 2025

Security design review

hannes-ucsc commented Jan 13, 2025 •

edited by achave11-ucsc

Loading

coveralls commented Jan 20, 2025 •

edited

Loading

codecov bot commented Jan 20, 2025 •

edited

Loading