Preview: Indexer groupby #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoriCremer
force-pushed
the
indexer-groupby
branch
from
0ca962a to
a64aafa
Compare
RoriCremer
force-pushed
the
indexer-groupby
branch
from
a64aafa to
685c502
Compare
melissachang
reviewed
Nov 1, 2018
There was a problem hiding this comment.
Is this PR ready for review?
I want to confirm that this PR improves performance. Can you do the following:
- Create a view of broad-gdr-encode-storage.encode_2018_10_06.files. Either only keep donors with < 500 files, or only keep files with path (WHERE NOT path IS NULL).
- Delete index
- Run indexer at head. What happens -- does indexer crash? How long until crash, and how many documents are indexed at that point?
- Run indexer with this PR. How long does indexing take?
| participant_row_dicts = [] | ||
| for _, row in participant_group.iterrows(): | ||
| sample_index = 0 | ||
| for sample_id, row in participant_group.iloc[0:5000].iterrows(): # |
There was a problem hiding this comment.
This should not be hard-coded here.
|
Never mind about running indexer at head -- I remember I tried that. Just let me know when this is ready for review. |
|
Sorry, I realized I hadn't tried head with the smaller BQ table. So please do this after all.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.