Fix default value for sample_file_columns (#203). #204
Conversation
|
(I'll fix up the tests once I see the export work on our deployment) |
| @@ -129,11 +129,12 @@ def _get_entities_dict(cohort_name, query, filter_arr): | |||
| } | |||
| }) | |||
|
|
|||
| sample_id = current_app.config['SAMPLE_ID_COLUMN'] | |||
| sample_items = [] | ||
| for doc in _get_doc_generator(filter_arr): | ||
| sample_items.extend([{ | ||
| 'entityType': 'sample', | ||
| 'entityName': s['sample_id'] | ||
| 'entityName': s[sample_id] |
| @@ -237,6 +237,7 @@ def _process_facets(es): | |||
| # Elasticsearch field type, optional UI facet description and Elasticsearch | |||
| # facet. | |||
| app.app.config['FACET_INFO'] = facets | |||
| app.app.config['EXTRA_FACET_INFO'] = {} | |||
There was a problem hiding this comment.
I think it makes sense to have a proper default value here, but I actually would've thought this would be handled correctly here. Where are you seeing the key not found error thrown from?
There was a problem hiding this comment.
I think this is the line that was throwing (I didn't save the stack trace, but it was in the export controller and that's the first place where the key is accessed). I was hitting the error by:
- Opening the explorer
- Checking a few boxes in the pre-curated search facets
- Clicking the export button
If it matters, I didn't have a bigquery.json in my explorer config at the time. I've noticed that some of the configuration code paths only get hit when it's present on deploy.
There was a problem hiding this comment.
Ah the missing biquery.json was probably it, thanks for the explanation!
danxmoran
force-pushed
the
dm-fix-config-default-203
branch
from
7eacdf6 to
1ef552f
Compare
danxmoran
force-pushed
the
dm-fix-config-default-203
branch
from
1ef552f to
3c155d6
Compare
* Change default value for sample_file_columns to a dictionary. * Read sample ID column from config on export. * Make sure EXTRA_FACET_INFO is initialized.
* update to get all * add scroll styling to card lists * update test for larger data sample * note for scaling > 1000 Will need further fleshed out UI design * switch to 500 <-- 600 * cleanup styling * remove unnecessary css file * Fix default values in API layer. (#204) * Change default value for sample_file_columns to a dictionary. * Read sample ID column from config on export. * Make sure EXTRA_FACET_INFO is initialized. * setup test
Fixes #203 ... eventually (another error popped up, will push again to this branch once I've got things working).