PR feedback: simplify div logic

DataBiosphere · Nov 13, 2024 · fc9188c · fc9188c
1 parent 559a198
commit fc9188c
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/components/data_search/DatasetSearchFooter.tsx b/src/components/data_search/DatasetSearchFooter.tsx
@@ -13,6 +13,9 @@ export const DatasetSearchFooter = (props: DatasetSearchFooterProps) => {
   const selectedStudies = _.uniq(
     _.filter(datasets, dataset => selectedDatasets.includes(dataset.datasetId))
       .map(dataset => dataset.study.studyId));
+  const datasetText = selectedDatasets.length > 1 ? 'datasets' : 'dataset';
+  const studyText = selectedStudies.length > 1 ? 'studies' : 'study';
+
   return <div style={{
     position: 'fixed',
     bottom: 0,
@@ -25,9 +28,7 @@ export const DatasetSearchFooter = (props: DatasetSearchFooterProps) => {
     border: '1px solid #DEDEDE',
     alignItems: 'center'
   }}>
-    {selectedDatasets.length > 1 && selectedStudies.length > 1 && (<div style={{paddingRight: 15}}> {selectedDatasets.length} Datasets selected from {selectedStudies.length} Studies </div>)}
-    {selectedDatasets.length > 1 && selectedStudies.length === 1 && (<div style={{paddingRight: 15}}> {selectedDatasets.length} Datasets selected from 1 Study </div>)}
-    {selectedDatasets.length === 1 && (<div style={{paddingRight: 15}}> 1 Dataset selected from 1 Study </div>)}
+    <div style={{paddingRight: 15}}>{selectedDatasets.length} {datasetText} selected from {selectedStudies.length} {studyText}</div>
     <Button
       variant='contained'
       onClick={onClick}