[DUOS-2635] Implemented disabled checkboxes for data submission form #2329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushtong
approved these changes
Sep 12, 2023
Comment on lines
485
to
490
| label({ | ||
| className: `regular-checkbox ${!isValid(validation) ? 'errored' : ''}`, | ||
| htmlFor: `${id}`, | ||
| style: disabled ? { cursor: 'not-allowed' } : null | ||
| }, [toggleText]) | ||
| ]); |
There was a problem hiding this comment.
I'm seeing two things unrelated to the ticket that shouldn't hold up this PR, maybe we can address separately.
- I had the question of Why is the input not inside the label? and needed to look that up. I learned HTML in the 90's, but apparently it can be before, around, or after
- We're still using hyperscript here ... would be really nice to get rid of that and stick with jsx.
There was a problem hiding this comment.
- Yes! And I also don't understand why the input tag is not directly creating the checkbox.
- Definitely agree!
nmalfroy
approved these changes
Sep 12, 2023
| @@ -485,6 +485,7 @@ export const FormInputCheckbox = (config) => { | |||
| label({ | |||
| className: `regular-checkbox ${!isValid(validation) ? 'errored' : ''}`, | |||
| htmlFor: `${id}`, | |||
| style: disabled ? { cursor: 'not-allowed' } : null | |||
There was a problem hiding this comment.
I'm assuming that this will default to pointer in the null case?
There was a problem hiding this comment.
Yes, that's right!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DUOS-2635
Summary
Have you read Terra's Contributing Guide lately? If not, do that first.