Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2658] Validation Bug in Data Submission Form #2331

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[DUOS-2658] Validation Bug in Data Submission Form #2331

merged 1 commit into from
Sep 19, 2023

Conversation

hams7504
Copy link
Contributor

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2658

Summary

  • Commented out the code causing the error

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@hams7504 hams7504 requested a review from a team as a code owner September 18, 2023 21:16
@hams7504 hams7504 requested a review from rushtong September 18, 2023 21:17
bstitson-broad
bstitson-broad reviewed Sep 18, 2023
View reviewed changes
src/assets/schemas/DataRegistrationV1Validation.js
}
errors++;
}
// Default ajv URI validation is failing with "TypeError: formats12 is not a function"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hams7504 is this the section you commented out? I found it by searching for "//" in the diff.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's right! I added line 776 to clarify why I commented out this section.

rushtong
rushtong approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

nmalfroy
nmalfroy approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@nmalfroy nmalfroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok? Seems fairly mechanical

@hams7504 hams7504 merged commit 277f58d into develop Sep 19, 2023
10 checks passed
@hams7504 hams7504 deleted the hm-duos-2658-data-submitter-validation-bug branch September 19, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bstitson-broad bstitson-broad bstitson-broad left review comments

@nmalfroy nmalfroy nmalfroy approved these changes

@rushtong rushtong rushtong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hams7504 @rushtong @nmalfroy @bstitson-broad