Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DUOS-2662][DUOS-2663][DUOS-2664][DUOS-2665][DUOS-2666][DUOS-2667] Support the branded data libraries #2338

Merged
merged 11 commits into from
Sep 29, 2023

Conversation

fboulnois
Copy link
Contributor

@fboulnois fboulnois commented Sep 26, 2023

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2662
https://broadworkbench.atlassian.net/browse/DUOS-2663
https://broadworkbench.atlassian.net/browse/DUOS-2664
https://broadworkbench.atlassian.net/browse/DUOS-2665
https://broadworkbench.atlassian.net/browse/DUOS-2666
https://broadworkbench.atlassian.net/browse/DUOS-2667

Summary

Adds the initial version of the Broad, DUOS, MGB, eLwazi, and My Institution data libraries.


Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois requested a review from a team as a code owner September 26, 2023 16:49
@fboulnois fboulnois changed the title Support the Broad data library [DUOS-2662] Support the Broad data library Sep 26, 2023
@fboulnois fboulnois changed the title [DUOS-2662] Support the Broad data library [DUOS-2662][DUOS-2663] Support the branded data libraries Sep 26, 2023
@fboulnois fboulnois changed the title [DUOS-2662][DUOS-2663] Support the branded data libraries [DUOS-2662][DUOS-2663][DUOS-2664] Support the branded data libraries Sep 26, 2023
@fboulnois fboulnois force-pushed the fb-duos-2662-broad-data-library branch from 120f343 to 9a5e9e5 Compare September 26, 2023 20:22
src/pages/DatasetSearch.js Outdated Show resolved Hide resolved
@fboulnois fboulnois changed the title [DUOS-2662][DUOS-2663][DUOS-2664] Support the branded data libraries [DUOS-2662][DUOS-2663][DUOS-2664][DUOS-2665] Support the branded data libraries Sep 27, 2023
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this approach 👍🏽 One possible abstraction idea would be around versions. I could see that being an external configuration object passed into the component as a route prop instead of looking for it in the DatasetSearch component.

@fboulnois fboulnois changed the title [DUOS-2662][DUOS-2663][DUOS-2664][DUOS-2665] Support the branded data libraries [DUOS-2662][DUOS-2663][DUOS-2664][DUOS-2665][DUOS-2666] Support the branded data libraries Sep 28, 2023
Copy link
Contributor

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@fboulnois fboulnois force-pushed the fb-duos-2662-broad-data-library branch from e829eb0 to e00e8b0 Compare September 28, 2023 20:41
@fboulnois fboulnois changed the title [DUOS-2662][DUOS-2663][DUOS-2664][DUOS-2665][DUOS-2666] Support the branded data libraries [DUOS-2662][DUOS-2663][DUOS-2664][DUOS-2665][DUOS-2666][DUOS-2667] Support the branded data libraries Sep 28, 2023
@fboulnois fboulnois force-pushed the fb-duos-2662-broad-data-library branch from e00e8b0 to cb7ec83 Compare September 28, 2023 20:46
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks good 👍🏽

@fboulnois fboulnois merged commit ab5b077 into develop Sep 29, 2023
10 checks passed
@fboulnois fboulnois deleted the fb-duos-2662-broad-data-library branch September 29, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants