-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DUOS-2662][DUOS-2663][DUOS-2664][DUOS-2665][DUOS-2666][DUOS-2667] Support the branded data libraries #2338
Conversation
120f343
to
9a5e9e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this approach 👍🏽 One possible abstraction idea would be around versions
. I could see that being an external configuration object passed into the component as a route prop instead of looking for it in the DatasetSearch
component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
e829eb0
to
e00e8b0
Compare
e00e8b0
to
cb7ec83
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good 👍🏽
Addresses
https://broadworkbench.atlassian.net/browse/DUOS-2662
https://broadworkbench.atlassian.net/browse/DUOS-2663
https://broadworkbench.atlassian.net/browse/DUOS-2664
https://broadworkbench.atlassian.net/browse/DUOS-2665
https://broadworkbench.atlassian.net/browse/DUOS-2666
https://broadworkbench.atlassian.net/browse/DUOS-2667
Summary
Adds the initial version of the Broad, DUOS, MGB, eLwazi, and My Institution data libraries.
Have you read Terra's Contributing Guide lately? If not, do that first.